Skip to content

Commit 528df5f

Browse files
committed
review fixes
1 parent 45685c8 commit 528df5f

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

.github/workflows/build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ permissions:
1616
contents: write
1717

1818
env:
19-
version: m138-c1caa59365c-2
19+
version: m138-9e6b5bff162-2
2020

2121
jobs:
2222
macos:

README.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,21 +14,21 @@ Prebuilt binaries can be found [in releases](https://github.com/JetBrains/skia-p
1414
3. Update `version` in [.github/workflows/build.yml](https://github.com/JetBrains/skia-pack/blob/master/.github/workflows/build.yml).
1515

1616
## Building locally
17-
17+
Replace SKIA_VERSION with the version you want to build, for example `m138-9e6b5bff162`.
1818
Note: Better check build.yml for the detailed command for your machine
1919

2020
```sh
21-
python3 script/checkout.py --version m138-c1caa59365c
21+
python3 script/checkout.py --version SKIA_VERSION
2222
python3 script/build.py
23-
python3 script/archive.py --version m138-c1caa59365c
23+
python3 script/archive.py --version SKIA_VERSION
2424
```
2525

2626
To build a debug build:
2727

2828
```sh
29-
python3 script/checkout.py --version m138-c1caa59365c
29+
python3 script/checkout.py --version SKIA_VERSION
3030
python3 script/build.py --build-type Debug
31-
python3 script/archive.py --version m138-c1caa59365c --build-type Debug
31+
python3 script/archive.py --version SKIA_VERSION --build-type Debug
3232
```
3333

3434
### Windows-specific

0 commit comments

Comments
 (0)