Add support for button color binding and unit tests#40
Merged
IvanMurzak merged 19 commits intomainfrom Nov 24, 2025
Merged
Conversation
…icMultiColorBinder
- Implement tests for switching themes in buttons, ensuring colors update correctly across different states. - Add tests for updating colors in buttons, verifying that changes in the theme reflect accurately. - Create tests for handling alpha overrides in button colors, ensuring that alpha values are preserved when switching themes. - Introduce tests for button states, confirming that all five button states (Normal, Highlighted, Pressed, Selected, Disabled) are correctly set and retrieved. - Validate the creation of MultiColorBinder instances, ensuring proper initialization of color entries and labels. - Implement error handling tests for invalid indices and labels when setting colors.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces button color binding support for the Unity theme system. It implements a flexible multi-color binding architecture that allows UI components (specifically buttons) to bind their color properties to theme colors, with support for alpha overrides and dynamic theme switching.
Key changes:
- Implemented a base multi-color binder architecture with
BaseMultiColorBinderandGenericMultiColorBinder - Added
ButtonColorBinderto bind all 5 button states (Normal, Highlighted, Pressed, Selected, Disabled) - Created comprehensive test suites covering creation, color setting, theme switching, and alpha overrides
Reviewed changes
Copilot reviewed 50 out of 50 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| MultiColorBinderEntry.cs | Data structure for storing color entry label and binding data |
| BaseMultiColorBinder.cs | Abstract base class providing core multi-color binding functionality and lifecycle management |
| BaseMultiColorBinder.Public.cs | Public API methods for setting colors and alpha overrides by index or label |
| BaseMultiColorBinder.Validate.cs | Validation logic for color entries in editor |
| GenericMultiColorBinder.cs | Generic implementation for components requiring multi-color binding |
| ButtonColorBinder.cs | Concrete implementation for Unity Button ColorBlock binding |
| MultiColorBinderEntryDrawer.cs | Custom property drawer for editor UI |
| TestUtils.*.cs | Test utility functions and constants for multi-color binder testing |
| TestMultiColorBinder.*.cs | Comprehensive test suites for runtime and editor modes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Unity-Theme/Assets/root/Scripts/Binders/Base/BaseMultiColorBinder.Public.cs
Outdated
Show resolved
Hide resolved
Unity-Theme/Assets/root/Scripts/Binders/Base/BaseMultiColorBinder.Public.cs
Outdated
Show resolved
Hide resolved
Unity-Theme/Assets/root/Scripts/Binders/Base/GenericMultiColorBinder.cs
Outdated
Show resolved
Hide resolved
Unity-Theme/Assets/root/Scripts/Binders/Base/GenericMultiColorBinder.cs
Outdated
Show resolved
Hide resolved
Unity-Theme/Assets/root/Scripts/Binders/Base/BaseMultiColorBinder.cs
Outdated
Show resolved
Hide resolved
…d logging and error handling
…r naming and update connection configuration
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 61 out of 61 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Unity-Theme/Assets/root/Scripts/Binders/Base/BaseMultiColorBinder.Public.cs
Show resolved
Hide resolved
Unity-Theme/Assets/root/Scripts/Binders/Base/BaseMultiColorBinder.Validate.cs
Outdated
Show resolved
Hide resolved
- Implemented SelectableColorBinder to bind theme colors to Unity Selectable's ColorBlock, supporting all five states: Normal, Highlighted, Pressed, Selected, and Disabled. - Created associated tests to ensure functionality for Selectable states, including color setting, alpha overrides, and theme switching. - Updated existing test cases to replace Button references with Selectable, ensuring comprehensive coverage for the new binder.
…or Selectable components
…lor updates correctly
- Simplified test methods in TestMultiColorBinder.SwitchTheme.cs by replacing manual theme switching and color assertions with utility methods for better readability and maintainability. - Updated TestMultiColorBinder.UpdateColors.cs to utilize utility methods for color updates and assertions, reducing code duplication. - Refactored TestMultiColorBinder.ButtonStates.cs to leverage utility methods for state color assertions and alpha overrides, enhancing test clarity. - Streamlined TestMultiColorBinder.Create.cs by using utility methods for initialization and label checks, improving test structure. - Enhanced TestMultiColorBinder.SetColors.Alpha.cs and TestMultiColorBinder.SetColors.cs to utilize utility methods for setting colors and validating states, ensuring consistent testing practices.
…ved color entry management
…Block Refactor BaseMultiColorBinder to improve color entry initialization
…rBinderEntriesDrawer, and MultiColorBinderEntryDrawer for consistency; update FixedMultiColorBinderEntries to use colorBindings instead of entries.
…ate entry labels; adjust margin settings in MultiColorBinderEntryDrawer for improved layout consistency
…uration for Unity tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce support for button color binding using
MultiColorBinderEntryandGenericMultiColorBinder. Implement comprehensive unit tests to validate color updates across different button states and themes, ensuring accurate handling of color entries and error scenarios.