Merge pull request #2 from jessedearing/add-ln-loggers

Add log methods with `ln` at the end

Author: talpert

log.go

@@ -20,6 +20,11 @@ type Logger interface {
 	Warn(msg ...interface{})
 	Error(msg ...interface{})
 
+	Debugln(msg ...interface{})
+	Infoln(msg ...interface{})
+	Warnln(msg ...interface{})
+	Errorln(msg ...interface{})
+
 	Debugf(format string, args ...interface{})
 	Infof(format string, args ...interface{})
 	Warnf(format string, args ...interface{})
@@ -86,6 +91,30 @@ func (b *simple) Error(msg ...interface{}) {
 	stdlog.Printf("[ERROR] %s %s", fmt.Sprint(msg...), pretty(b.fields))
 }
 
+// Debugln log line message
+func (b *simple) Debugln(msg ...interface{}) {
+	a := fmt.Sprintln(msg...)
+	stdlog.Println("[DEBUG]", a[:len(a)-1], pretty(b.fields))
+}
+
+// Infoln log line message
+func (b *simple) Infoln(msg ...interface{}) {
+	a := fmt.Sprintln(msg...)
+	stdlog.Println("[INFO]", a[:len(a)-1], pretty(b.fields))
+}
+
+// Warnln log line message
+func (b *simple) Warnln(msg ...interface{}) {
+	a := fmt.Sprintln(msg...)
+	stdlog.Println("[WARN]", a[:len(a)-1], pretty(b.fields))
+}
+
+// Errorln log line message
+func (b *simple) Errorln(msg ...interface{}) {
+	a := fmt.Sprintln(msg...)
+	stdlog.Println("[ERROR]", a[:len(a)-1], pretty(b.fields))
+}
+
 // Debugf log message with formatting
 func (b *simple) Debugf(format string, args ...interface{}) {
 	stdlog.Print(fmt.Sprintf("[DEBUG] "+format, args...), " ", pretty(b.fields))
@@ -144,6 +173,18 @@ func (n *noop) Warn(msg ...interface{}) {}
 // Error log message no-op
 func (n *noop) Error(msg ...interface{}) {}
 
+// Debugln line log message no-op
+func (n *noop) Debugln(msg ...interface{}) {}
+
+// Infoln line log message no-op
+func (n *noop) Infoln(msg ...interface{}) {}
+
+// Warnln line log message no-op
+func (n *noop) Warnln(msg ...interface{}) {}
+
+// Errorln line log message no-op
+func (n *noop) Errorln(msg ...interface{}) {}
+
 // Debugf log message with formatting no-op
 func (n *noop) Debugf(format string, args ...interface{}) {}
 

log_test.go

@@ -45,6 +45,26 @@ var _ = Describe("simple logger", func() {
 			}
 		})
 
+		It("prints all log line levels", func() {
+			logFuncs := map[string]func(...interface{}){
+				"DEBUG": l.Debugln,
+				"INFO":  l.Infoln,
+				"WARN":  l.Warnln,
+				"ERROR": l.Errorln,
+			}
+
+			for level, logFunc := range logFuncs {
+				logFunc("hi", "there")
+
+				b := newOut.Bytes()
+				newOut.Reset()
+				Expect(string(b)).To(SatisfyAll(
+					ContainSubstring("hi there"),
+					ContainSubstring(level),
+				))
+			}
+		})
+
 		It("prints all log levels on formatted", func() {
 			logFuncs := map[string]func(string, ...interface{}){
 				"DEBUG": l.Debugf,
@@ -152,6 +172,19 @@ var _ = Describe("noop logger", func() {
 	})
 
 	Context("happy path", func() {
+		It("does nothing", func() {
+			logFuncs := map[string]func(...interface{}){
+				"DEBUG": l.Debugln,
+				"INFO":  l.Infoln,
+				"WARN":  l.Warnln,
+				"ERROR": l.Errorln,
+			}
+
+			for _, logFunc := range logFuncs {
+				logFunc("hi there")
+			}
+		})
+
 		It("does nothing", func() {
 			logFuncs := map[string]func(...interface{}){
 				"DEBUG": l.Debug,

shims/logrus/logrus_test.go

@@ -47,6 +47,26 @@ var _ = Describe("logrus logger", func() {
 			}
 		})
 
+		It("prints all log levels", func() {
+			logFuncs := map[string]func(...interface{}){
+				"debug": l.Debugln,
+				"info":  l.Infoln,
+				"warn":  l.Warnln,
+				"error": l.Errorln,
+			}
+
+			for level, logFunc := range logFuncs {
+				logFunc("hi", "there")
+
+				b := newOut.Bytes()
+				newOut.Reset()
+				Expect(string(b)).To(SatisfyAll(
+					ContainSubstring("hi there"),
+					ContainSubstring("level="+level),
+				))
+			}
+		})
+
 		It("prints all log levels on formatted", func() {
 			logFuncs := map[string]func(string, ...interface{}){
 				"debug": l.Debugf,

shims/testlog/testlog.go

@@ -49,6 +49,30 @@ func (t *TestLogger) write(level, msg string) {
 	t.count.inc()
 }
 
+//Debugln log line message
+func (t *TestLogger) Debugln(msg ...interface{}) {
+	a := fmt.Sprintln(msg...)
+	t.write("DEBUG", a[:len(a)-1])
+}
+
+//Infoln log line message
+func (t *TestLogger) Infoln(msg ...interface{}) {
+	a := fmt.Sprintln(msg...)
+	t.write("INFO", a[:len(a)-1])
+}
+
+//Warnln log line message
+func (t *TestLogger) Warnln(msg ...interface{}) {
+	a := fmt.Sprintln(msg...)
+	t.write("WARN", a[:len(a)-1])
+}
+
+//Errorln log line message
+func (t *TestLogger) Errorln(msg ...interface{}) {
+	a := fmt.Sprintln(msg...)
+	t.write("ERROR", a[:len(a)-1])
+}
+
 // Debug log message
 func (t *TestLogger) Debug(msg ...interface{}) {
 	t.write("DEBUG", fmt.Sprint(msg...))

shims/testlog/testlog_test.go

@@ -42,6 +42,26 @@ var _ = Describe("test logger", func() {
 			}
 		})
 
+		It("prints all log line levels", func() {
+			logFuncs := map[string]func(...interface{}){
+				"DEBUG": l.Debugln,
+				"INFO":  l.Infoln,
+				"WARN":  l.Warnln,
+				"ERROR": l.Errorln,
+			}
+
+			for level, logFunc := range logFuncs {
+				logFunc("hi", "there")
+
+				b := testOut.Bytes()
+				testOut.Reset()
+				Expect(string(b)).To(SatisfyAll(
+					ContainSubstring("hi there"),
+					ContainSubstring(level),
+				))
+			}
+		})
+
 		It("prints all log levels on formatted", func() {
 			logFuncs := map[string]func(string, ...interface{}){
 				"DEBUG": l.Debugf,