Skip to content

bug: Duplicate more-query condition in handle_chat #80

@QuantumByte-01

Description

@QuantumByte-01

Problem

In handle_chat (agents.py line 506):

if more_count is not None or (query.strip().lower() in {"more", "next", "continue", ...}):

The second or condition is already handled inside _is_more_query which returns None for those exact words. The branch is dead code and makes the logic confusing.

Fix

Simplify to:

if query.strip().lower() in {"more", "next", "continue", "more please", "show more", "keep going"} or more_count is not None:

Or refactor _is_more_query to return a sentinel that covers both cases.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions