Regards mpaland#123: Suppressing the spurious "uninitialized" warning in older versions of GCC.

eyalroz · eyalroz · commit 77c56db9e8a4 · 2022-10-17T14:58:29.000+03:00
diff --git a/src/printf/printf.c b/src/printf/printf.c
@@ -624,7 +624,15 @@ static double apply_scaling(double num, struct scaling_factor normalization)
 
 static double unapply_scaling(double normalized, struct scaling_factor normalization)
 {
+#ifdef __GNUC__
+// accounting for a static analysis bug in GCC 6.x and earlier
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
+#endif
   return normalization.multiply ? normalized / normalization.raw_factor : normalized * normalization.raw_factor;
+#ifdef __GNUC__
+#pragma GCC diagnostic pop
+#endif
 }
 
 static struct scaling_factor update_normalization(struct scaling_factor sf, double extra_multiplicative_factor)

Original file line number	Diff line number	Diff line change
`@@ -624,7 +624,15 @@ static double apply_scaling(double num, struct scaling_factor normalization)`
`624`	`624`
`625`	`625`	`static double unapply_scaling(double normalized, struct scaling_factor normalization)`
`626`	`626`	`{`
	`627`	`+#ifdef __GNUC__`
	`628`	`+// accounting for a static analysis bug in GCC 6.x and earlier`
	`629`	`+#pragma GCC diagnostic push`
	`630`	`+#pragma GCC diagnostic ignored "-Wmaybe-uninitialized"`
	`631`	`+#endif`
`627`	`632`	`return normalization.multiply ? normalized / normalization.raw_factor : normalized * normalization.raw_factor;`
	`633`	`+#ifdef __GNUC__`
	`634`	`+#pragma GCC diagnostic pop`
	`635`	`+#endif`
`628`	`636`	`}`
`629`	`637`
`630`	`638`	`static struct scaling_factor update_normalization(struct scaling_factor sf, double extra_multiplicative_factor)`