TileProcessor: check success_ in scheduleT2T1 in single threaded mode

Author: Grok Compression

src/lib/core/codestream/decompress/CodeStreamDecompress.cpp

@@ -632,16 +632,11 @@ bool CodeStreamDecompress::schedule(ITileProcessor* tileProcessor, bool multiTil
     // T2 + T1 decompression
     // Once we schedule a processor for T1 compression, we will destroy it
     // regardless of success or not
-    if(!tileProcessor->scheduleT2T1(
-           &coderPool_, multiTile ? scratchImage_->getBounds() : headerImage_->getBounds(),
-           multiTile ? postMultiTile(tileProcessor) : postSingleTile(tileProcessor),
-           decompressTileFutureManager_))
-    {
-      grklog.error("Failed to decompress tile %u/%u", tileProcessor->getIndex(),
-                   tilesToDecompress_.getTotalNumTiles());
-      success_ = false;
-      return false;
-    }
+    tileProcessor->scheduleT2T1(
+        &coderPool_, multiTile ? scratchImage_->getBounds() : headerImage_->getBounds(),
+        multiTile ? postMultiTile(tileProcessor) : postSingleTile(tileProcessor),
+        decompressTileFutureManager_);
+
     return true;
   }
 }

src/lib/core/tile_processor/ITileProcessor.h

@@ -126,9 +126,8 @@ struct ITileProcessor
    * @param unreducedImageBounds Bounds of the unreduced image
    * @param post Post-scheduling callback function
    * @param futures Manager for tile futures
-   * @return true if scheduling succeeds, false otherwise
    */
-  virtual bool scheduleT2T1(CoderPool* coderPool, Rect32 unreducedImageBounds,
+  virtual void scheduleT2T1(CoderPool* coderPool, Rect32 unreducedImageBounds,
                             std::function<void()> post, TileFutureManager& futures) = 0;
 
   /**

src/lib/core/tile_processor/TileProcessor.cpp

@@ -452,7 +452,9 @@ bool TileProcessor::decompressWithTLM(const std::shared_ptr<TPFetchSeq>& tilePar
   if(!decompressPrepareWithTLM(tilePartFetchSeq))
     return false;
 
-  return scheduleT2T1(coderPool, unreducedImageBounds, post, futures);
+  scheduleT2T1(coderPool, unreducedImageBounds, post, futures);
+
+  return true;
 }
 
 bool TileProcessor::readSOT(IStream* stream, uint8_t* headerData, uint16_t headerSize,
@@ -973,7 +975,7 @@ void TileProcessor::post_decompressT2T1(GrkImage* scratch)
   }
 }
 
-bool TileProcessor::scheduleT2T1(CoderPool* coderPool, Rect32 unreducedImageBounds,
+void TileProcessor::scheduleT2T1(CoderPool* coderPool, Rect32 unreducedImageBounds,
                                  std::function<void()> post, TileFutureManager& futures)
 {
   unreducedImageWindow_ = unreducedImageBounds;
@@ -1160,10 +1162,13 @@ bool TileProcessor::scheduleT2T1(CoderPool* coderPool, Rect32 unreducedImageBoun
   else
   {
     t2Parse();
-    allocAndSchedule();
-    post();
+    if(success_)
+    {
+      allocAndSchedule();
+      if(success_)
+        post();
+    }
   }
-  return true;
 }
 
 uint8_t TileProcessor::getMaxNumDecompressResolutions(void)

src/lib/core/tile_processor/TileProcessor.h

@@ -107,9 +107,8 @@ struct TileProcessor : virtual public ITileProcessor
    * @param unreducedImageBounds
    * @param post
    * @param futures
-   * @return true if successful
    */
-  bool scheduleT2T1(CoderPool* coderPool, Rect32 unreducedImageBounds, std::function<void()> post,
+  void scheduleT2T1(CoderPool* coderPool, Rect32 unreducedImageBounds, std::function<void()> post,
                     TileFutureManager& futures) override;
   /**
    * @brief Performs post T2+T1 processing