Skip to content

Conversation

@knoepfel
Copy link
Member

@knoepfel knoepfel commented Feb 9, 2026

Closes #299

@greenc-FNAL
Copy link
Contributor

Review the full CodeQL report for details.

@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
phlex/core/node_catalog.cpp 50.00% 0 Missing and 1 partial ⚠️

❌ Your project check has failed because the head coverage (75.77%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

@@            Coverage Diff             @@
##             main     #301      +/-   ##
==========================================
+ Coverage   75.69%   75.77%   +0.07%     
==========================================
  Files         125      126       +1     
  Lines        2946     2951       +5     
  Branches      519      521       +2     
==========================================
+ Hits         2230     2236       +6     
  Misses        497      497              
+ Partials      219      218       -1     
Flag Coverage Δ
unittests 75.77% <85.71%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
phlex/core/declared_output.cpp 100.00% <100.00%> (ø)
phlex/core/declared_output.hpp 100.00% <100.00%> (ø)
phlex/core/edge_maker.hpp 100.00% <100.00%> (ø)
phlex/core/node_catalog.cpp 73.33% <50.00%> (+4.10%) ⬆️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76af3af...45811ad. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@knoepfel knoepfel force-pushed the write-provided-products branch from ad1740d to 6926687 Compare February 10, 2026 15:18
@marcpaterno
Copy link
Member

Is it feasible to add a test that verifies that a product that was created by a provider is actually received by a writer? If the current testing does that, then I did not understand the test configuration well enough to discern it.

@knoepfel
Copy link
Member Author

Is it feasible to add a test that verifies that a product that was created by a provider is actually received by a writer? If the current testing does that, then I did not understand the test configuration well enough to discern it.

Yes, this is possible. I will add a test.

@knoepfel knoepfel force-pushed the write-provided-products branch from 6926687 to 206262e Compare February 10, 2026 22:24
@knoepfel knoepfel requested a review from marcpaterno February 10, 2026 22:30
@knoepfel knoepfel force-pushed the write-provided-products branch from 206262e to 45811ad Compare February 10, 2026 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable writing of data products from providers

3 participants