Apply suggestions from code review

Co-authored-by: Copilot <[email protected]>

Author: greenc-FNAL

.github/workflows/cmake-build.yaml

@@ -8,7 +8,7 @@ on:
   push:
     branches: [ main, develop ]
   schedule:
-    - cron: '07 18 * * 6'
+    - cron: '7 18 * * 6'
   workflow_dispatch:
     inputs:
       ref:

CMakeLists.txt

@@ -197,7 +197,7 @@ add_subdirectory(plugins)
 # Link Perfetto to phlex executable if enabled
 if(ENABLE_PERFETTO AND TARGET phlex)
   target_link_libraries(phlex PRIVATE Perfetto::Perfetto)
-  target_compile_definitions(phlex PRIVATE PERFETTO_ENABLE_TRACING=1)
+
 endif()
 
 if(PHLEX_USE_FORM)

Modules/FindPerfetto.cmake

@@ -20,9 +20,11 @@ find_file(
 find_package_handle_standard_args(Perfetto REQUIRED_VARS Perfetto_INCLUDE_DIR Perfetto_SOURCE)
 
 if(Perfetto_FOUND AND NOT TARGET Perfetto::Perfetto)
+  find_package(Threads REQUIRED)
   add_library(perfetto_impl STATIC "${Perfetto_SOURCE}")
   target_include_directories(perfetto_impl PUBLIC "${Perfetto_INCLUDE_DIR}")
   target_compile_definitions(perfetto_impl PUBLIC PERFETTO_ENABLE_TRACING=1)
+  target_link_libraries(perfetto_impl PUBLIC Threads::Threads)
   add_library(Perfetto::Perfetto ALIAS perfetto_impl)
 endif()