Fix argument validation, error handling, and exception correctness

- Replace manual argument throws with ThrowIf helpers (ThrowIfNull, ThrowIfNullOrEmpty) in ElasticReadOnlyRepositoryBase

- Fix VersionedIndex alias error using wrong response variable, which reported the wrong error message and exception on alias fetch failures

- Fix incomplete error message in AliasExistsAsync (missing 'exists')

- Log error when RefreshForConsistency fails instead of silently swallowing

Made-with: Cursor

Author: niemyjski

src/Foundatio.Repositories.Elasticsearch/Configuration/VersionedIndex.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Collections.Generic;
 using System.Diagnostics;
 using System.Linq;
@@ -105,7 +105,7 @@ protected async Task<bool> AliasExistsAsync(string alias)
         if (response.ApiCall.Success)
             return response.Exists;
 
-        throw new RepositoryException(response.GetErrorMessage($"Error checking to see if alias {alias}"), response.OriginalException);
+        throw new RepositoryException(response.GetErrorMessage($"Error checking to see if alias {alias} exists"), response.OriginalException);
     }
 
     public override async Task DeleteAsync()
@@ -257,7 +257,7 @@ protected virtual async Task<IList<IndexInfo>> GetIndexesAsync(int version = -1)
         _logger.LogRequest(aliasResponse);
 
         if (!aliasResponse.IsValid)
-            throw new RepositoryException(response.GetErrorMessage($"Error getting index aliases for {filter}"), response.OriginalException);
+            throw new RepositoryException(aliasResponse.GetErrorMessage($"Error getting index aliases for {filter}"), aliasResponse.OriginalException);
 
         var indices = response.Records
             .Where(i => version < 0 || GetIndexVersion(i.Index) == version)

src/Foundatio.Repositories.Elasticsearch/Repositories/ElasticReadOnlyRepositoryBase.cs

@@ -357,8 +357,7 @@ public Task<FindResults<T>> FindAsync(IRepositoryQuery query, ICommandOptions op
         if (options.HasAsyncQueryId())
         {
             var queryId = options.GetAsyncQueryId();
-            if (String.IsNullOrEmpty(queryId))
-                throw new ArgumentNullException("AsyncQueryId must not be null");
+            ArgumentException.ThrowIfNullOrEmpty(queryId, nameof(queryId));
 
             var response = await _client.AsyncSearch.GetAsync<TResult>(queryId, s =>
             {
@@ -437,8 +436,7 @@ public async Task RemoveQueryAsync(string queryId)
 
     private async Task<FindResults<TResult>> GetNextPageFunc<TResult>(FindResults<TResult> previousResults, IRepositoryQuery query, ICommandOptions options) where TResult : class, new()
     {
-        if (previousResults == null)
-            throw new ArgumentException(nameof(previousResults));
+        ArgumentNullException.ThrowIfNull(previousResults);
 
         string scrollId = previousResults.GetScrollId();
         if (!String.IsNullOrEmpty(scrollId))
@@ -536,8 +534,7 @@ public virtual async Task<CountResult> CountAsync(IRepositoryQuery query, IComma
         if (options.HasAsyncQueryId())
         {
             var queryId = options.GetAsyncQueryId();
-            if (String.IsNullOrEmpty(queryId))
-                throw new ArgumentNullException("AsyncQueryId must not be null");
+            ArgumentException.ThrowIfNullOrEmpty(queryId, nameof(queryId));
 
             var response = await _client.AsyncSearch.GetAsync<T>(queryId, s =>
             {
@@ -835,12 +832,14 @@ protected bool ShouldReturnDocument(T document, ICommandOptions options)
 
     protected async Task RefreshForConsistency(IRepositoryQuery query, ICommandOptions options)
     {
-        // if not using eventual consistency, force a refresh
         if (options.GetConsistency(DefaultConsistency) != Consistency.Eventual)
         {
             string[] indices = ElasticIndex.GetIndexesByQuery(query);
             var response = await _client.Indices.RefreshAsync(indices);
-            _logger.LogRequest(response);
+            if (response.IsValid)
+                _logger.LogRequest(response);
+            else
+                _logger.LogErrorRequest(response, "Failed to refresh indices for immediate consistency");
         }
     }