Skip to content

Commit 57cc6ed

Browse files
Address code review feedback: improve type annotation and logging in sources.py
Agent-Logs-Url: https://github.com/FlexMeasures/flexmeasures/sessions/319e247a-b8ab-4340-95e2-d1fd41e39d4e Co-authored-by: BelhsanHmida <[email protected]>
1 parent b39ab79 commit 57cc6ed

1 file changed

Lines changed: 8 additions & 1 deletion

File tree

flexmeasures/api/v3_0/sources.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
from __future__ import annotations
22

3+
import logging
4+
35
from flask_classful import FlaskView, route
46
from flask_json import as_json
57
from flask_security import current_user, auth_required
@@ -56,9 +58,14 @@ def _version_key(source: DataSource):
5658
try:
5759
return Version(source.version or "0.0.0")
5860
except InvalidVersion:
61+
logging.getLogger(__name__).warning(
62+
"DataSource %d has an invalid version string %r; treating as 0.0.0",
63+
source.id,
64+
source.version,
65+
)
5966
return Version("0.0.0")
6067

61-
best: dict[tuple, DataSource] = {}
68+
best: dict[tuple[str, str, str | None], DataSource] = {}
6269
for source in sources:
6370
key = (source.name, source.type, source.model)
6471
if key not in best:

0 commit comments

Comments
 (0)