-
Notifications
You must be signed in to change notification settings - Fork 501
Fix "unsaved changes" badge positioning on Edit Feature modal tabs #6935
Copy link
Copy link
Open
Labels
front-endIssue related to the React Front End DashboardIssue related to the React Front End Dashboard
Description
Description
The "unsaved changes" badge (purple dot with *) on the Edit Feature modal's "Segment Overrides" tab has positioning issues:
- It overflows below the tab underline instead of aligning vertically with the tab label
- It remains visible even when switching to a different tab (e.g. "Identity Overrides"), appearing under an inactive tab
Screenshots
Steps to reproduce
- Open any feature (Edit Feature modal)
- Click on the "Segment Overrides" tab
- Make a change to a segment override (toggle enabled, change value, etc.) — the purple
*badge appears - Observe the badge sits below the tab underline
- Switch to "Identity Overrides" tab — the badge still shows under the now-inactive "Segment Overrides" tab
Expected behaviour
- The badge should align vertically centred with the tab label text
- The badge positioning should not overflow below the tab underline
Relevant files
- Badge rendered here:
web/components/modals/create-feature/index.js(lines 934-937) — the.unreaddiv inside the tab label - Tab button styling:
web/styles/components/_tabs.scss - Tab component:
web/components/navigation/TabMenu/Tabs.tsx - Tab button component:
web/components/navigation/TabMenu/TabButton.tsx - Base badge styling:
web/styles/project/_utils.scss(lines 155-171) —.unreadclass (global, used across the app)
How to test
- Run
ENV=local npm run dev - Open a feature with segment overrides
- Toggle or edit a segment override to trigger the unsaved state
- Verify the badge aligns with the tab text and doesn't overflow below the underline
- Check other tab bars across the app (permissions, settings) for visual regressions
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
front-endIssue related to the React Front End DashboardIssue related to the React Front End Dashboard