Skip to content

Commit 2968f50

Browse files
committed
feat!: drop node 18 support by updating related configs
1 parent c3349e8 commit 2968f50

56 files changed

Lines changed: 125 additions & 176 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.circleci/config.yml

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -179,21 +179,21 @@ workflows:
179179
name: build-v<< matrix.node-version >>
180180
matrix:
181181
parameters:
182-
node-version: [ '18.20', '20.18', '22.12' ]
182+
node-version: [ '20.18', '22.12' ]
183183
- test:
184184
requires:
185185
- build-v<< matrix.node-version >>
186186
name: test-v<< matrix.node-version >>
187187
matrix:
188188
parameters:
189-
node-version: [ '18.20', '20.18', '22.12' ]
189+
node-version: [ '20.18', '22.12' ]
190190
- lint:
191191
requires:
192192
- build-v<< matrix.node-version >>
193193
name: lint-v<< matrix.node-version >>
194194
matrix:
195195
parameters:
196-
node-version: [ '18.20', '20.18', '22.12' ]
196+
node-version: [ '20.18', '22.12' ]
197197

198198
release-please:
199199
when:
@@ -219,7 +219,7 @@ workflows:
219219
name: build-v<< matrix.node-version >>
220220
matrix:
221221
parameters:
222-
node-version: [ '18.20', '20.18', '22.12' ]
222+
node-version: [ '20.18', '22.12' ]
223223
- test:
224224
filters:
225225
<<: *filters_release_build
@@ -228,7 +228,7 @@ workflows:
228228
name: test-v<< matrix.node-version >>
229229
matrix:
230230
parameters:
231-
node-version: [ '18.20', '20.18', '22.12' ]
231+
node-version: [ '20.18', '22.12' ]
232232
- lint:
233233
filters:
234234
<<: *filters_release_build
@@ -237,7 +237,7 @@ workflows:
237237
name: lint-v<< matrix.node-version >>
238238
matrix:
239239
parameters:
240-
node-version: [ '18.20', '20.18', '22.12' ]
240+
node-version: [ '20.18', '22.12' ]
241241
- publish:
242242
context: npm-publish-token
243243
filters:
@@ -259,7 +259,7 @@ workflows:
259259
name: build-v<< matrix.node-version >>
260260
matrix:
261261
parameters:
262-
node-version: [ '18.20', '20.18', '22.12' ]
262+
node-version: [ '20.18', '22.12' ]
263263
- test:
264264
filters:
265265
<<: *filters_prerelease_build
@@ -268,7 +268,7 @@ workflows:
268268
name: test-v<< matrix.node-version >>
269269
matrix:
270270
parameters:
271-
node-version: [ '18.20', '20.18', '22.12' ]
271+
node-version: [ '20.18', '22.12' ]
272272
- lint:
273273
filters:
274274
<<: *filters_prerelease_build
@@ -277,7 +277,7 @@ workflows:
277277
name: lint-v<< matrix.node-version >>
278278
matrix:
279279
parameters:
280-
node-version: [ '18.20', '20.18', '22.12' ]
280+
node-version: [ '20.18', '22.12' ]
281281
- prepublish:
282282
context: npm-publish-token
283283
filters:
@@ -301,15 +301,15 @@ workflows:
301301
name: build-v<< matrix.node-version >>
302302
matrix:
303303
parameters:
304-
node-version: [ '18.20', '20.18', '22.12' ]
304+
node-version: [ '20.18', '22.12' ]
305305
- test:
306306
requires:
307307
- build-v<< matrix.node-version >>
308308
context: next-nightly-build
309309
name: test-v<< matrix.node-version >>
310310
matrix:
311311
parameters:
312-
node-version: [ '18.20', '20.18', '22.12' ]
312+
node-version: [ '20.18', '22.12' ]
313313

314314
# Prior to producing a development orb (which requires credentials) basic validation, linting, and even unit testing can be performed.
315315
# This workflow will run on every commit

core/cli/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050
"zod-validation-error": "^3.4.1"
5151
},
5252
"engines": {
53-
"node": "18.x || 20.x || 22.x"
53+
"node": ">=20.x"
5454
},
5555
"files": [
5656
"/bin",

core/cli/test/__snapshots__/config.test.ts.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14591,7 +14591,7 @@ exports[`loadConfig should load an invalid config when not validating 1`] = `
1459114591
},
1459214592
"options": {
1459314593
"cimgNodeVersions": [
14594-
"18.19-browsers",
14594+
"20.19-browsers",
1459514595
],
1459614596
"runOnTag": true,
1459714597
"tagFilterRegex": "/^v\\d+\\.\\d+\\.\\d+(-.+)?/",

core/create/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,6 @@
5959
"extends": "../../package.json"
6060
},
6161
"engines": {
62-
"node": "18.x || 20.x || 22.x"
62+
"node": ">=20.x"
6363
}
6464
}

lib/doppler/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,6 @@
3434
"winston": "^3.17.0"
3535
},
3636
"engines": {
37-
"node": "18.x || 20.x || 22.x"
37+
"node": ">=20.x"
3838
}
3939
}

lib/error/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,6 @@
2626
"tslib": "^2.8.1"
2727
},
2828
"engines": {
29-
"node": "18.x || 20.x || 22.x"
29+
"node": ">=20.x"
3030
}
3131
}

lib/logger/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,6 @@
3636
"@types/triple-beam": "^1.3.5"
3737
},
3838
"engines": {
39-
"node": "18.x || 20.x || 22.x"
39+
"node": ">=20.x"
4040
}
4141
}

lib/logger/src/helpers.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ export function hookConsole(logger: Logger, processName: string): () => void {
105105
if (typeof encoding === 'function') {
106106
return originalWrite(message, encoding)
107107
} else {
108-
return originalWrite(message, encoding, writeCallback as (err?: Error) => void)
108+
return originalWrite(message, encoding, writeCallback as (err?: Error | null) => void)
109109
}
110110
} else {
111111
if (typeof encoding === 'function') {

lib/state/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,6 @@
2727
"tslib": "^2.8.1"
2828
},
2929
"engines": {
30-
"node": "18.x || 20.x || 22.x"
30+
"node": ">=20.x"
3131
}
3232
}

lib/wait-for-ok/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,6 @@
3030
"extends": "../../package.json"
3131
},
3232
"engines": {
33-
"node": "18.x || 20.x || 22.x"
33+
"node": ">=20.x"
3434
}
3535
}

0 commit comments

Comments
 (0)