bug: 'npm install' postInstall fails in Windows because no sh (or sed)

[rjstone]

Steps To Reproduce

I cloned the repo in windows and followed the instructions, but it fails at the point where 'sh' is expected to exist.
Fails at this point in npm install:

R:\gitrepos\icestudio > npm install --legacy-peer-deps

> icestudio@0.13.4w postinstall
> sh scripts/postInstall.sh && grunt getcollection && npmpd && cd app && npm install

'sh' is not recognized as an internal or external command,
operable program or batch file.
npm ERR! code 1
npm ERR! path R:\gitrepos\icestudio
npm ERR! command failed
npm ERR! command C:\WINDOWS\system32\cmd.exe /d /s /c sh scripts/postInstall.sh && grunt getcollection && npmpd && cd app && npm install

It looks like scripts/postInstall.sh only does this:

$SED_CMD 's/options\.srcDir/\/\/options.srcDir/g' node_modules/grunt-nw-builder/tasks/nw.js

to comment out that one line in node_modules/grunt-nw-builder/tasks/nw.js, so I just did that manually (though I'm unsure of the purpose) and edited package.json to remove the shell script so that postinstall is now:

"postinstall": "grunt getcollection && npmpd && cd app && npm install"

and everything will install and run after that.

Suggestion: Use a node.js postinstall script to do this instead of a sh script.

Expected behavior

R:\gitrepos\icestudio > npm install --legacy-peer-deps

> icestudio@0.13.4w postinstall
> grunt getcollection && npmpd && cd app && npm install

Executing Gruntfile.js...
Running "clean:collection" (clean) task
>> 1 path cleaned.

Running "wget:collection" (wget) task
Downloaded 1 file

Running "unzip:using-router" (unzip) task
Created "app/resources" directory

Running "clean:collectionFile" (clean) task
>> 1 path cleaned.

Done.
No specific dependencies on this platform: win32

up to date, audited 191 packages in 2s

20 packages are looking for funding
  run `npm fund` for details

21 vulnerabilities (1 low, 3 moderate, 13 high, 4 critical)

To address all issues possible (including breaking changes), run:
  npm audit fix --force

Some issues need review, and may require choosing
a different dependency.

Run `npm audit` for details.

> icestudio@0.13.4w prepare
> npm run setupDevEnv


> icestudio@0.13.4w setupDevEnv
> grunt setupDevEnv

Executing Gruntfile.js...
Running "setupDevEnv" task
✅ Hook pre-commit installed

Done.

up to date, audited 487 packages in 14s

48 packages are looking for funding
  run `npm fund` for details

23 vulnerabilities (5 moderate, 18 high)

To address issues that do not require attention, run:
  npm audit fix

To address all issues possible (including breaking changes), run:
  npm audit fix --force

Some issues need review, and may require choosing
a different dependency.

Run `npm audit` for details.

Actual behavior

Fails at this point in npm install:

R:\gitrepos\icestudio > npm install --legacy-peer-deps

> icestudio@0.13.4w postinstall
> sh scripts/postInstall.sh && grunt getcollection && npmpd && cd app && npm install

'sh' is not recognized as an internal or external command,
operable program or batch file.
npm ERR! code 1
npm ERR! path R:\gitrepos\icestudio
npm ERR! command failed
npm ERR! command C:\WINDOWS\system32\cmd.exe /d /s /c sh scripts/postInstall.sh && grunt getcollection && npmpd && cd app && npm install

Screenshots or video

No response

Desktop (please complete the following information)

OS Name: Microsoft Windows 11 Pro
OS Version: 10.0.26100 N/A Build 26100
OS Manufacturer: Microsoft Corporation
OS Configuration: Standalone Workstation
OS Build Type: Multiprocessor Free

I'm using the nw.js that was installed from the spec in package.json which is:

nw.js v0.95.0
Node v23.3.0
Chromium 132.0.6834.84
commit hash: 079dc40-a79a1f7-def931e-31f9a3a

Web console trace

n/a

Additional context

No response

[rjstone]

FYI, I also tried doing this using Git Bash (which seems to be the usual way to get compatibility with (ba)sh scripts in windows, at least for git operations), but unfortunately grunt explicitly uses cmd.exe to invoke the postInstall command pipeline. So in windows grunt will do ......\cmd.exe .... script.sh && stuff && stuff no matter the parent shell type.

[rjstone]

Hmm..... Actually it does seem to be working in Git Bash

$ npm install --legacy-peer-deps

> icestudio@0.13.4w postinstall
> sh scripts/postInstall.sh && grunt getcollection && npmpd && cd app && npm install

✅ Post install actions succeeded
Executing Gruntfile.js...
Running "clean:collection" (clean) task
>> 0 paths cleaned.

Running "wget:collection" (wget) task
Downloaded 1 file

Running "unzip:using-router" (unzip) task
Created "app/resources" directory

Running "clean:collectionFile" (clean) task
>> 1 path cleaned.

Done.
No specific dependencies on this platform: win32

added 190 packages, and audited 191 packages in 5s

20 packages are looking for funding
  run `npm fund` for details

21 vulnerabilities (1 low, 3 moderate, 13 high, 4 critical)

To address all issues possible (including breaking changes), run:
  npm audit fix --force

Some issues need review, and may require choosing
a different dependency.

Run `npm audit` for details.

> icestudio@0.13.4w prepare
> npm run setupDevEnv


> icestudio@0.13.4w setupDevEnv
> grunt setupDevEnv

Executing Gruntfile.js...
Running "setupDevEnv" task
✅ Hook pre-commit installed

Done.

added 486 packages, and audited 487 packages in 37s

48 packages are looking for funding
  run `npm fund` for details

23 vulnerabilities (5 moderate, 18 high)

To address issues that do not require attention, run:
  npm audit fix

To address all issues possible (including breaking changes), run:
  npm audit fix --force

Some issues need review, and may require choosing
a different dependency.

Run `npm audit` for details.

rjstone@Mars MINGW64 /r/gitrepos/icestudio (develop)
$

Affected file looks like:

rjstone@Mars MINGW64 /r/gitrepos/icestudio (develop)
$ cat node_modules/grunt-nw-builder/tasks/nw.js
module.exports = function (grunt) {
  grunt.registerMultiTask(
    "nwjs",
    "Package Node.js app as NW.js app",
    async function () {
      const done = this.async();
      const options = this.options();
      // Set //options.srcDir via the Grunt task's src option:
      //options.srcDir = this.data.src;

      let nwbuild = undefined;

      try {
        nwbuild = await import("nw-builder");
        nwbuild = nwbuild.default;
      } catch (e) {
        console.log(e);
      }

      await nwbuild(options);
      await done();
    },
  );
};