Fix actionlint config path resolution after cd into REPO_ROOT#53
Merged
coleaeason merged 1 commit intomainfrom Feb 11, 2026
Merged
Fix actionlint config path resolution after cd into REPO_ROOT#53coleaeason merged 1 commit intomainfrom
coleaeason merged 1 commit intomainfrom
Conversation
After `cd "$REPO_ROOT"`, the config file checks still referenced `$REPO_ROOT/.github/actionlint.yml`, creating a double-nested path (e.g., FuzzyBot/FuzzyBot/.github/actionlint.yml) that never exists. This caused the script to always fall back to the GitHub-Actions default config, silently ignoring repo-local actionlint configs. Use paths relative to cwd (which is already inside the repo after the cd) instead of prefixing with $REPO_ROOT. Co-authored-by: Justin Persaud <[email protected]>
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
|
@MelvinBot can you sign the CLA noted in the comment above? |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
CLABotify
added a commit
to Expensify/CLA
that referenced
this pull request
Feb 11, 2026
justinpersaud
requested review from
coleaeason and
stitesExpensify
and removed request for
mollfpr
coleaeason
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
After
cd "$REPO_ROOT", the config file checks inactionlint.shstill referenced$REPO_ROOT/.github/actionlint.yml, creating a double-nested path (e.g.,FuzzyBot/FuzzyBot/.github/actionlint.yml) that never exists. This caused the script to always fall back to the GitHub-Actions default config, silently ignoring repo-localactionlint.ymlconfigs for every repo in the org that has one.The fix uses paths relative to the current working directory (which is already inside the repo after the
cd) instead of prefixing with$REPO_ROOT.Related Issues
$ https://github.com/Expensify/Expensify/issues/599362
Manual Tests
.github/actionlint.yml(e.g., FuzzyBot), the script should now log"Using actionlint file from this repo"instead of"Using default Github-Actions repo actionlint.yml"..github/actionlint.yml, the fallback to the GitHub-Actions config should still work as before.actionlintcheck should pass after this fix is merged.Linked PRs
N/A