[$250] Expense - Amount field opens not here page when report status is Done

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.74-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: Exp https://test-management.browserstack.com/projects/2219752/test-runs/TR-2323/folder/13176791/41237172/1065364466
Email or phone of affected tester (no customers): sdonsjdoijsoisjiosj@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Critical User Impact
Device used: Mac 26.1 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Workflows are disabled.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Create an expense.
4. Open expense report.
5. Click More > Retract.
6. Click More > Split.
7. Click Save.
8. Click Submit.
9. Open any split.
10. Click Amount field.

Expected Result:

Amount field should open split details page.

Actual Result:

Amount field opens not here page when report status is Done.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug7025160_1765301415573.10.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022001075957875285361
• Upwork Job ID: 2001075957875285361
• Last Price Increase: 2025-12-30
• Automatic offers:
• tsa321 | Contributor | 110008716

Issue Owner

Current Issue Owner: @alitoshmatov

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Eskalifer1]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense - Amount field opens not here page when report status is Done

What is the root cause of that problem?

We display “not found” here:

App/src/pages/iou/SplitExpensePage.tsx

Line 371 in 4f4b76a

<FullPageNotFoundView shouldShow={!reportID || isEmptyObject(draftTransaction) || !isSplitAvailable}>

And in this case, because the report has already been submitted, we end up in this if:

App/src/libs/ReportSecondaryActionUtils.ts

Lines 103 to 105 in 4f4b76a

	if (report.statusNum && report.statusNum >= CONST.REPORT.STATUS_NUM.CLOSED) {
	return false;
	}

This leads to the not-found page being displayed.

I think that in this case, this field should not be interactive, since the report is already in the done status. But it can be edited because there is a check here:

App/src/components/ReportActionItem/MoneyRequestView.tsx

Lines 267 to 268 in 4f4b76a

	const canEditAmount =
	isEditable && (canEditFieldOfMoneyRequest(parentReportAction, CONST.EDIT_REQUEST_FIELD.AMOUNT, undefined, isChatReportArchived) || (isExpenseSplit && isSplitAvailable));

And in this case, even if we have isExpenseSplit - true, and isSplitAvailable - false, the function canEditFieldOfMoneyRequest will still return true, and we will consider that the field can be edited.

What changes do you think we should make in order to solve the problem?

In the case of isExpenseSplit, we always need to check whether isSplitAvailable:

const canEditAmount =
        isEditable &&
        (isExpenseSplit
            ? canEditFieldOfMoneyRequest(parentReportAction, CONST.EDIT_REQUEST_FIELD.AMOUNT, undefined, isChatReportArchived) && isSplitAvailable
            : canEditFieldOfMoneyRequest(parentReportAction, CONST.EDIT_REQUEST_FIELD.AMOUNT, undefined, isChatReportArchived));

PS: If there are other parts that need to be fixed, we can do that too.

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[tsa321]

🚨 Edited by proposal-police: This proposal was edited at 2025-12-20 01:14:34 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense - Amount details page show not found instead of split expense details when report status is completed

What is the root cause of that problem?

The not found page:

App/src/pages/iou/SplitExpensePage.tsx

Line 371 in 3eca92a

<FullPageNotFoundView shouldShow={!reportID || isEmptyObject(draftTransaction) || !isSplitAvailable}>

is displayed because the isSplitAvailable is false:

App/src/pages/iou/SplitExpensePage.tsx

Line 94 in 3eca92a

const isSplitAvailable = report && transaction && isSplitAction(currentReport, [transaction], originalTransaction, currentPolicy);

which is because it is not a splitAction caused by report status is closed:

App/src/libs/ReportSecondaryActionUtils.ts

Lines 103 to 105 in 3eca92a

	if (report.statusNum && report.statusNum >= CONST.REPORT.STATUS_NUM.CLOSED) {
	return false;
	}

What changes do you think we should make in order to solve the problem?

Based on the expected result, Admin or Manager can edit the split details page. We can change the condition in:

App/src/libs/ReportSecondaryActionUtils.ts

Line 103 in 3eca92a

if (report.statusNum && report.statusNum >= CONST.REPORT.STATUS_NUM.CLOSED) {

to be:

if (report.statusNum && report.statusNum >= CONST.REPORT.STATUS_NUM.CLOSED && !(isAdmin || isManager)) {

then adjust the item.isEditable accordingly.
In here:

App/src/pages/iou/SplitExpensePage.tsx

Line 289 in 3eca92a

isEditable: (item.statusNum ?? 0) < CONST.REPORT.STATUS_NUM.CLOSED,

We need to allow the item to be editable when the user is an admin or a manager. or simply use isSplitAvailable after it is fixed

What alternative solutions did you explore? (1)

We can determine whether we can show the split amount page using canEditAmount of money request view:

App/src/components/ReportActionItem/MoneyRequestView.tsx

Lines 267 to 268 in 4f4b76a

	const canEditAmount =
	isEditable && (canEditFieldOfMoneyRequest(parentReportAction, CONST.EDIT_REQUEST_FIELD.AMOUNT, undefined, isChatReportArchived) || (isExpenseSplit && isSplitAvailable));

or directly by using the isEditable && canEditFieldOfMoneyRequest(parentReportAction, CONST.EDIT_REQUEST_FIELD.AMOUNT... (but more testing, but the logic is similar to the MoneyRequestView whether it allow to display the split amount page)

instead of using !isSplitAvailable in:

App/src/pages/iou/SplitExpensePage.tsx

Line 371 in 3eca92a

<FullPageNotFoundView shouldShow={!reportID || isEmptyObject(draftTransaction) || !isSplitAvailable}>

What alternative solutions did you explore? (2)

we could use useShowNotFoundPageInIOUStep like used in ioustepdescript / or amount and others.

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[dmkt9]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Amount field opens not here page when report status is Done.

What is the root cause of that problem?

1. Since isSplitAvailable === false, the FullPageNotFoundView will be displayed.
   

   App/src/pages/iou/SplitExpensePage.tsx

   Line 371 in 3eca92a

   <FullPageNotFoundView shouldShow={!reportID || isEmptyObject(draftTransaction) || !isSplitAvailable}>

2. isSplitAvailable === false because the following if condition evaluates to true.
   

   App/src/libs/ReportSecondaryActionUtils.ts

   Lines 103 to 105 in 3eca92a

   	if (report.statusNum && report.statusNum >= CONST.REPORT.STATUS_NUM.CLOSED) {
   	return false;
   	}

What changes do you think we should make in order to solve the problem?

Because the BE still supports changing the amount even when the report status is Done, we should also allow editing. Therefore, in the case where the workflow is disabled, we will change the condition to compare against CONST.REPORT.STATUS_NUM.CLOSED:

• Do not display FullPageNotFoundView if the workflow is disabled.
  

  App/src/libs/ReportSecondaryActionUtils.ts

  Line 103 in 3eca92a

  if (report.statusNum && report.statusNum >= CONST.REPORT.STATUS_NUM.CLOSED) {

if (
    report.statusNum &&
    (isSubmitAndClose(policy) && isInstantSubmitEnabled(policy) ? report.statusNum > CONST.REPORT.STATUS_NUM.CLOSED : report.statusNum >= CONST.REPORT.STATUS_NUM.CLOSED)
) {

• Allow editing the amount in SplitExpensePage.
  

  App/src/pages/iou/SplitExpensePage.tsx

  Line 289 in 3eca92a

  isEditable: (item.statusNum ?? 0) < CONST.REPORT.STATUS_NUM.CLOSED,

    isEditable:
        !item?.statusNum ||
        (isSubmitAndClose(policy) && isInstantSubmitEnabled(policy) ? item.statusNum <= CONST.REPORT.STATUS_NUM.CLOSED : item.statusNum < CONST.REPORT.STATUS_NUM.CLOSED),

What alternative solutions did you explore? (Optional)

N/A

2025-12-10.16-39-39.mp4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022001075957875285361

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)