Skip to content

Commit dadbd5b

Browse files
committed
Refactor delete methods in ParcelContentManager, ItemStorageManager, and DeliveryManager to return boolean indicating success
1 parent 7b10101 commit dadbd5b

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

src/main/java/com/eternalcode/parcellockers/content/ParcelContentManager.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,10 @@ public ParcelContent create(UUID parcel, List<ItemStack> items) {
5151
return content;
5252
}
5353

54-
public CompletableFuture<Void> delete(UUID parcel) {
54+
public CompletableFuture<Boolean> delete(UUID parcel) {
5555
return this.contentRepository.delete(parcel).thenApply(i -> {
5656
this.cache.invalidate(parcel);
57-
return null;
57+
return i > 0;
5858
});
5959
}
6060

src/main/java/com/eternalcode/parcellockers/delivery/DeliveryManager.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,10 @@ public Delivery create(UUID parcel, Instant deliveryTimestamp) {
3939
return delivery;
4040
}
4141

42-
public CompletableFuture<Void> delete(UUID parcel) {
42+
public CompletableFuture<Boolean> delete(UUID parcel) {
4343
return this.deliveryRepository.delete(parcel).thenApply(i -> {
4444
this.deliveryCache.invalidate(parcel);
45-
return null;
45+
return i > 0;
4646
});
4747
}
4848

src/main/java/com/eternalcode/parcellockers/itemstorage/ItemStorageManager.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,9 +61,9 @@ private void cacheAll() {
6161
itemStorage))));
6262
}
6363

64-
public CompletableFuture<Void> delete(UUID parcel) {
64+
public CompletableFuture<Boolean> delete(UUID parcel) {
6565
this.cache.invalidate(parcel);
66-
return this.itemStorageRepository.delete(parcel).thenApply(i -> null);
66+
return this.itemStorageRepository.delete(parcel).thenApply(i -> i > 0);
6767
}
6868

6969
public CompletableFuture<Void> deleteAll(CommandSender sender, NoticeService noticeService) {

0 commit comments

Comments
 (0)