Debug scene: Fix a crash when foreground interpreter stack is empty

Author: florianessl

src/game_interpreter.cpp

@@ -2044,13 +2044,13 @@ std::optional<bool> Game_Interpreter::HandleDynRpgScript(const lcf::rpg::EventCo
 	if (Player::IsPatchDynRpg() || Player::HasEasyRpgExtensions()) {
 		if (com.string.empty() || com.string[0] != '@') {
 			// Not a DynRPG command
-			return std::nullopt;
+			return {};
 		}
 
 		if (!Player::IsPatchDynRpg() && Player::HasEasyRpgExtensions()) {
 			// Only accept commands starting with @easyrpg_
 			if (!StartsWith(com.string, "@easyrpg_")) {
-				return std::nullopt;
+				return {};
 			}
 		}
 
@@ -2073,19 +2073,20 @@ std::optional<bool> Game_Interpreter::HandleDynRpgScript(const lcf::rpg::EventCo
 
 		return Main_Data::game_dynrpg->Invoke(command, this);
 	}
+	return {};
 }
 
 std::optional<bool> Game_Interpreter::HandleDestinyScript(const lcf::rpg::EventCommand& com) {
 	// DestinyScript
 	if (Player::IsPatchDestiny()) {
 		if (com.string.empty() || com.string[0] != '$') {
 			// Not a DestinyScript
-			return std::nullopt;
+			return {};
 		}
 
 		return Main_Data::game_destiny->Main(GetFrame());
 	}
-	return std::nullopt;
+	return {};
 }
 
 bool Game_Interpreter::CommandComment(const lcf::rpg::EventCommand &com) {

src/window_interpreter.cpp

@@ -199,10 +199,13 @@ void Window_Interpreter::DrawDescriptionLines() {
 	rect = GetItemRect(i++);
 	contents->ClearRect(rect);
 
-	auto str_ex_type = std::string(Game_Interpreter_Shared::kExecutionType.tag(static_cast<int>(stack_display_items[0].type_ex)));
-	contents->TextDraw(rect.x, rect.y, Font::ColorDefault, "(");
-	contents->TextDraw(rect.x + 6, rect.y, Font::ColorHeal, str_ex_type);
-	contents->TextDraw(rect.x + 6 * (str_ex_type.length() + 1), rect.y, Font::ColorDefault, ")");
+
+	if (stack_display_items.size() > 0) {
+		auto str_ex_type = std::string(Game_Interpreter_Shared::kExecutionType.tag(static_cast<int>(stack_display_items[0].type_ex)));
+		contents->TextDraw(rect.x, rect.y, Font::ColorDefault, "(");
+		contents->TextDraw(rect.x + 6, rect.y, Font::ColorHeal, str_ex_type);
+		contents->TextDraw(rect.x + 6 * (str_ex_type.length() + 1), rect.y, Font::ColorDefault, ")");
+	}
 	contents->TextDraw(rect.x + rect.width / 2, rect.y, Font::ColorDefault, "Stack Size: ");
 	contents->TextDraw(GetWidth() - 16, rect.y, Font::ColorCritical, std::to_string(state.stack.size()), Text::AlignRight);
 }