Response from review

Author: olliesilvester

Dockerfile

@@ -28,7 +28,7 @@ COPY --from=build /venv/ /venv/
 COPY tests/test_data/beamline_parameters.txt tests/test_data/beamline_parameters.txt
 ENV PATH=/venv/bin:$PATH
 ARG BEAMLINE="dev"
-ENV BEAMLINE=${RUN_APP_IN_DEV_MODE}
+ENV BEAMLINE=${BEAMLINE}
 
 # change this entrypoint if it is not the same as the repo
 CMD daq-config-server

deployment/build_and_push.sh

@@ -57,7 +57,7 @@ echo "========================================="
 echo " "
 echo "Building ${MAIN_CONTAINER_NAME}"
 echo " "
-podman build --build-arg RUN_APP_IN_DEV_MODE=$MAIN_APP_DEV_MODE -t $MAIN_CONTAINER_NAME .
+podman build --build-arg -t $MAIN_CONTAINER_NAME .
 if [ $PUSH -gt 0 ]; then
     podman tag $MAIN_CONTAINER_NAME $MAIN_CONTAINER_TAG
     podman push $MAIN_CONTAINER_NAME $MAIN_CONTAINER_TAG

src/daq_config_server/app.py

@@ -28,7 +28,7 @@ def get_configuration(file_path: Path):
     https://github.com/DiamondLightSource/daq-config-server/issues/67, this endpoint
     will convert commonly read files to a dictionary format
     """
-    if not file_path.exists():
+    if not file_path.is_file():
         raise FileNotFoundError(f"File {file_path} cannot be found")
 
     with file_path.open("r", encoding="utf-8") as f:

src/daq_config_server/client.py

@@ -1,5 +1,5 @@
 from logging import Logger, getLogger
-from typing import TypeVar
+from typing import Any, TypeVar
 
 import requests
 
@@ -22,7 +22,7 @@ def _get(
         r = requests.get(self._url + endpoint + (f"/{item}" if item else ""))
         return r.json()
 
-    def read_unformatted_file(self, file_path: str) -> BlParamDType | None:
+    def read_unformatted_file(self, file_path: str) -> Any:
         # After https://github.com/DiamondLightSource/daq-config-server/issues/67, we
         # can get specific formats, and then have better typing on
         # return values