Merge pull request #76 from DevopsArtFactory/codex/issue-58-s3-browser

feat: add S3 bucket browser

Author: YoungJinJung

go.mod

@@ -25,10 +25,14 @@ require (
 	github.com/aws/aws-sdk-go-v2/internal/configsources v1.4.21 // indirect
 	github.com/aws/aws-sdk-go-v2/internal/endpoints/v2 v2.7.21 // indirect
 	github.com/aws/aws-sdk-go-v2/internal/ini v1.8.6 // indirect
+	github.com/aws/aws-sdk-go-v2/internal/v4a v1.4.22 // indirect
 	github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs v1.68.0 // indirect
 	github.com/aws/aws-sdk-go-v2/service/iam v1.53.7 // indirect
 	github.com/aws/aws-sdk-go-v2/service/internal/accept-encoding v1.13.7 // indirect
-	github.com/aws/aws-sdk-go-v2/service/internal/presigned-url v1.13.20 // indirect
+	github.com/aws/aws-sdk-go-v2/service/internal/checksum v1.9.13 // indirect
+	github.com/aws/aws-sdk-go-v2/service/internal/presigned-url v1.13.21 // indirect
+	github.com/aws/aws-sdk-go-v2/service/internal/s3shared v1.19.21 // indirect
+	github.com/aws/aws-sdk-go-v2/service/s3 v1.98.0 // indirect
 	github.com/aws/aws-sdk-go-v2/service/signin v1.0.8 // indirect
 	github.com/aws/aws-sdk-go-v2/service/ssooidc v1.35.17 // indirect
 	github.com/aws/smithy-go v1.24.2 // indirect

go.sum

@@ -20,6 +20,8 @@ github.com/aws/aws-sdk-go-v2/internal/endpoints/v2 v2.7.21 h1:PEgGVtPoB6NTpPrBgq
 github.com/aws/aws-sdk-go-v2/internal/endpoints/v2 v2.7.21/go.mod h1:p+hz+PRAYlY3zcpJhPwXlLC4C+kqn70WIHwnzAfs6ps=
 github.com/aws/aws-sdk-go-v2/internal/ini v1.8.6 h1:qYQ4pzQ2Oz6WpQ8T3HvGHnZydA72MnLuFK9tJwmrbHw=
 github.com/aws/aws-sdk-go-v2/internal/ini v1.8.6/go.mod h1:O3h0IK87yXci+kg6flUKzJnWeziQUKciKrLjcatSNcY=
+github.com/aws/aws-sdk-go-v2/internal/v4a v1.4.22 h1:rWyie/PxDRIdhNf4DzRk0lvjVOqFJuNnO8WwaIRVxzQ=
+github.com/aws/aws-sdk-go-v2/internal/v4a v1.4.22/go.mod h1:zd/JsJ4P7oGfUhXn1VyLqaRZwPmZwg44Jf2dS84Dm3Y=
 github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs v1.68.0 h1:+/lmB/+i2oqkzbmlQxsW0kr/+wmJgmyiEF9VDJicX34=
 github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs v1.68.0/go.mod h1:PobeppEnIjw4pcgjFryNDZCTH7AiqZw0yb5r98Gvf9c=
 github.com/aws/aws-sdk-go-v2/service/ec2 v1.296.0 h1:98Miqj16un1WLNyM1RjVDhXYumhqZrQfAeG8i4jPG6o=
@@ -28,12 +30,20 @@ github.com/aws/aws-sdk-go-v2/service/iam v1.53.7 h1:n9YLiWtX3+6pTLZWvRJmtq5JIB9N
 github.com/aws/aws-sdk-go-v2/service/iam v1.53.7/go.mod h1:sP46Vo6MeJcM4s0ZXcG2PFmfiSyixhIuC/74W52yKuk=
 github.com/aws/aws-sdk-go-v2/service/internal/accept-encoding v1.13.7 h1:5EniKhLZe4xzL7a+fU3C2tfUN4nWIqlLesfrjkuPFTY=
 github.com/aws/aws-sdk-go-v2/service/internal/accept-encoding v1.13.7/go.mod h1:x0nZssQ3qZSnIcePWLvcoFisRXJzcTVvYpAAdYX8+GI=
+github.com/aws/aws-sdk-go-v2/service/internal/checksum v1.9.13 h1:JRaIgADQS/U6uXDqlPiefP32yXTda7Kqfx+LgspooZM=
+github.com/aws/aws-sdk-go-v2/service/internal/checksum v1.9.13/go.mod h1:CEuVn5WqOMilYl+tbccq8+N2ieCy0gVn3OtRb0vBNNM=
 github.com/aws/aws-sdk-go-v2/service/internal/presigned-url v1.13.20 h1:2HvVAIq+YqgGotK6EkMf+KIEqTISmTYh5zLpYyeTo1Y=
 github.com/aws/aws-sdk-go-v2/service/internal/presigned-url v1.13.20/go.mod h1:V4X406Y666khGa8ghKmphma/7C0DAtEQYhkq9z4vpbk=
+github.com/aws/aws-sdk-go-v2/service/internal/presigned-url v1.13.21 h1:c31//R3xgIJMSC8S6hEVq+38DcvUlgFY0FM6mSI5oto=
+github.com/aws/aws-sdk-go-v2/service/internal/presigned-url v1.13.21/go.mod h1:r6+pf23ouCB718FUxaqzZdbpYFyDtehyZcmP5KL9FkA=
+github.com/aws/aws-sdk-go-v2/service/internal/s3shared v1.19.21 h1:ZlvrNcHSFFWURB8avufQq9gFsheUgjVD9536obIknfM=
+github.com/aws/aws-sdk-go-v2/service/internal/s3shared v1.19.21/go.mod h1:cv3TNhVrssKR0O/xxLJVRfd2oazSnZnkUeTf6ctUwfQ=
 github.com/aws/aws-sdk-go-v2/service/rds v1.116.3 h1:H/ZYZ6QR4EXJAYElI5xkIM/yCz+A4uHIvWpzl+IfJks=
 github.com/aws/aws-sdk-go-v2/service/rds v1.116.3/go.mod h1:QbXW4coAMakHQhf1qhE0eVVCen9gwB/Kvn+HHHKhpGY=
 github.com/aws/aws-sdk-go-v2/service/route53 v1.62.4 h1:64aYPyHg3RjLvnMMSYQSg7aP+r1WRCPIS9SP9KfHjWg=
 github.com/aws/aws-sdk-go-v2/service/route53 v1.62.4/go.mod h1:bPSPzWTn9LSX6e0KPp4LlPoaspouZdKAlIdSMdhBBrs=
+github.com/aws/aws-sdk-go-v2/service/s3 v1.98.0 h1:foqo/ocQ7WqKwy3FojGtZQJo0FR4vto9qnz9VaumbCo=
+github.com/aws/aws-sdk-go-v2/service/s3 v1.98.0/go.mod h1:uoA43SdFwacedBfSgfFSjjCvYe8aYBS7EnU5GZ/YKMM=
 github.com/aws/aws-sdk-go-v2/service/secretsmanager v1.41.4 h1:9aZbO86sraeCIHHCpZhxwN9tnVy9POkSKzi4/TpT54A=
 github.com/aws/aws-sdk-go-v2/service/secretsmanager v1.41.4/go.mod h1:cxiXDhEzIq7Xx1BtmC4lGBK3SwAZ79+EUWiKawYHo14=
 github.com/aws/aws-sdk-go-v2/service/signin v1.0.8 h1:0GFOLzEbOyZABS3PhYfBIx2rNBACYcKty+XGkTgw1ow=

internal/app/app.go

@@ -48,6 +48,9 @@ const (
 	screenCWLogGroupList
 	screenCWLogStreamList
 	screenCWLogViewer
+	screenS3BucketList
+	screenS3ObjectList
+	screenS3ObjectDetail
 	screenContextPicker
 	screenContextAdd
 	screenLoading
@@ -198,6 +201,22 @@ type Model struct {
 	cwLogTailing            bool // live tail active
 	cwLogTailToken          *string
 
+	// S3 browser state
+	s3Buckets            []awsservice.S3Bucket
+	filteredS3Buckets    []awsservice.S3Bucket
+	s3BucketIdx          int
+	s3BucketFilter       string
+	s3BucketFilterActive bool
+	selectedS3Bucket     *awsservice.S3Bucket
+	s3Objects            []awsservice.S3Object
+	filteredS3Objects    []awsservice.S3Object
+	s3ObjectIdx          int
+	s3ObjectFilter       string
+	s3ObjectFilterActive bool
+	s3CurrentPrefix      string
+	s3PrefixStack        []string
+	selectedS3Object     *awsservice.S3ObjectDetail
+
 	// Context picker
 	configPath         string
 	ctxList            []config.ContextInfo
@@ -310,6 +329,7 @@ func (m Model) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
 		m.handleIAMMsg,
 		m.handleSecretMsg,
 		m.handleCloudWatchLogsMsg,
+		m.handleS3Msg,
 		m.handleContextMsg,
 	} {
 		if newM, cmd, handled := h(msg); handled {
@@ -378,6 +398,12 @@ func (m Model) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
 			return m.updateCWLogStreamList(msg)
 		case screenCWLogViewer:
 			return m.updateCWLogViewer(msg)
+		case screenS3BucketList:
+			return m.updateS3BucketList(msg)
+		case screenS3ObjectList:
+			return m.updateS3ObjectList(msg)
+		case screenS3ObjectDetail:
+			return m.updateS3ObjectDetail(msg)
 		case screenSecurityGroupList:
 			return m.updateSecurityGroupList(msg)
 		case screenSecurityGroupDetail:
@@ -487,6 +513,9 @@ func (m Model) updateFeatureList(msg tea.KeyMsg) (tea.Model, tea.Cmd) {
 			case domain.FeatureCloudWatchLogsBrowser:
 				m.screen = screenLoading
 				return m, m.loadCWLogGroups()
+			case domain.FeatureS3Browser:
+				m.screen = screenLoading
+				return m, m.loadS3Buckets()
 			case domain.FeatureSecurityGroupBrowser:
 				m.screen = screenLoading
 				return m, m.loadSecurityGroups()
@@ -566,6 +595,12 @@ func (m Model) View() string {
 		v = m.viewCWLogStreamList()
 	case screenCWLogViewer:
 		v = m.viewCWLogViewer()
+	case screenS3BucketList:
+		v = m.viewS3BucketList()
+	case screenS3ObjectList:
+		v = m.viewS3ObjectList()
+	case screenS3ObjectDetail:
+		v = m.viewS3ObjectDetail()
 	case screenSecurityGroupList:
 		v = m.viewSecurityGroupList()
 	case screenSecurityGroupDetail:

internal/app/app_test.go

@@ -1090,6 +1090,70 @@ func TestRotateAccessKeyFeatureUsesCurrentIdentityFlow(t *testing.T) {
 	}
 }
 
+func TestS3BrowserFeatureExistsInCatalog(t *testing.T) {
+	m := New(testConfig(), "", "dev")
+
+	for _, svc := range m.services {
+		if svc.Name != domain.ServiceS3 {
+			continue
+		}
+		if len(svc.Features) != 1 {
+			t.Fatalf("expected 1 S3 feature, got %d", len(svc.Features))
+		}
+		if svc.Features[0].Kind != domain.FeatureS3Browser {
+			t.Fatalf("expected S3 browser feature, got %s", svc.Features[0].Kind)
+		}
+		return
+	}
+
+	t.Fatal("expected S3 service in catalog")
+}
+
+func TestS3FeatureStartsBucketLoading(t *testing.T) {
+	m := New(testConfig(), "", "dev")
+	for _, svc := range m.services {
+		if svc.Name == domain.ServiceS3 {
+			m.features = svc.Features
+			break
+		}
+	}
+	m.screen = screenFeatureList
+
+	updated, cmd := m.Update(tea.KeyMsg{Type: tea.KeyEnter})
+	model := updated.(Model)
+	if model.screen != screenLoading {
+		t.Fatalf("expected loading screen, got %d", model.screen)
+	}
+	if cmd == nil {
+		t.Fatal("expected load S3 buckets command")
+	}
+}
+
+func TestS3ObjectListEscAtRootReturnsToBucketList(t *testing.T) {
+	m := New(testConfig(), "", "dev")
+	m.screen = screenS3ObjectList
+	m.selectedS3Bucket = &awsservice.S3Bucket{Name: "my-bucket"}
+	m.s3CurrentPrefix = ""
+
+	updated, _ := m.Update(tea.KeyMsg{Type: tea.KeyEsc})
+	model := updated.(Model)
+	if model.screen != screenS3BucketList {
+		t.Fatalf("expected bucket list screen, got %d", model.screen)
+	}
+}
+
+func TestS3ObjectListShowsBreadcrumb(t *testing.T) {
+	m := New(testConfig(), "", "dev")
+	m.screen = screenS3ObjectList
+	m.selectedS3Bucket = &awsservice.S3Bucket{Name: "my-bucket"}
+	m.s3CurrentPrefix = "logs/app/"
+
+	view := m.viewS3ObjectList()
+	if !strings.Contains(view, "Path: /logs/app") {
+		t.Fatalf("expected breadcrumb in S3 object list, got %q", view)
+	}
+}
+
 func TestCWLogViewerDownDoesNotOverflowShortEventList(t *testing.T) {
 	m := New(testConfig(), "", "dev")
 	m.screen = screenCWLogViewer

internal/app/messages.go

@@ -106,6 +106,20 @@ type cwLogEventsLoadedMsg struct {
 
 type cwLogTailTickMsg struct{}
 
+type s3BucketsLoadedMsg struct {
+	buckets []awsservice.S3Bucket
+}
+
+type s3ObjectsLoadedMsg struct {
+	bucket  string
+	prefix  string
+	objects awsservice.S3ListResult
+}
+
+type s3ObjectDetailLoadedMsg struct {
+	detail *awsservice.S3ObjectDetail
+}
+
 type secretsLoadedMsg struct {
 	secrets []awsservice.Secret
 }