Skip to content

fix(utils/build.sh): --platform to --docker-platform in help#6674

Merged
Eldolfin merged 2 commits intomainfrom
oscarld/fix-build-platform-arg
Apr 8, 2026
Merged

fix(utils/build.sh): --platform to --docker-platform in help#6674
Eldolfin merged 2 commits intomainfrom
oscarld/fix-build-platform-arg

Conversation

@Eldolfin
Copy link
Copy Markdown
Contributor

@Eldolfin Eldolfin commented Apr 2, 2026

Motivation

I had to figure out why --platform wasn't working even though it was advertised in the help message.

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

CODEOWNERS have been resolved as:

utils/build/build.sh                                                    @DataDog/system-tests-core

@datadog-datadog-prod-us1
Copy link
Copy Markdown

datadog-datadog-prod-us1 bot commented Apr 2, 2026 •
edited
Loading

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 94e35e8 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@Eldolfin Eldolfin marked this pull request as ready for review April 3, 2026 09:27
@Eldolfin Eldolfin requested a review from a team as a code owner April 3, 2026 09:27
@Eldolfin
Copy link
Copy Markdown
Contributor Author

Eldolfin commented Apr 8, 2026

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 bot commented Apr 8, 2026 •
edited
Loading

View all feedbacks in Devflow UI.

2026-04-08 09:41:59 UTC ℹ️ Start processing command /merge

2026-04-08 09:42:04 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 3m (p90).

2026-04-08 09:42:49 UTC ℹ️ MergeQueue: Retrying because an high priority merge request needed to be processed first. No action is needed from your side.

2026-04-08 09:43:01 UTC ⚠️ MergeQueue: This merge request build was cancelled

oscar.ledauphin@datadoghq.com cancelled this merge request build

@Eldolfin
Copy link
Copy Markdown
Contributor Author

Eldolfin commented Apr 8, 2026

/remove

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 bot commented Apr 8, 2026 •
edited
Loading

View all feedbacks in Devflow UI.

2026-04-08 09:42:30 UTC ℹ️ Start processing command /remove

2026-04-08 09:42:35 UTC ℹ️ Devflow: /remove

@Eldolfin Eldolfin merged commit a556c6e into main Apr 8, 2026
2020 of 2021 checks passed
@Eldolfin Eldolfin deleted the oscarld/fix-build-platform-arg branch April 8, 2026 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbeauchesne cbeauchesne cbeauchesne approved these changes

Assignees

No one assigned

Labels

mergequeue-status: removed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Eldolfin @cbeauchesne