chore: clean up actions

Author: hoolioh

.github/actions/Cargo.lock

@@ -4,7 +4,7 @@
 [workspace]
 members = [
     "ci-shared",
-    "ci-crates",
+    "crates-reporter",
     "clippy-annotation-reporter",
 ]
 resolver = "2"

.github/actions/Cargo.toml

@@ -10,6 +10,7 @@ publish = false
 
 [dependencies]
 anyhow = "1.0"
+cargo_metadata = "0.23.1"
 log = "0.4"
 toml = "0.8"
 serde = { version = "1", features = ["derive"] }

.github/actions/ci-crates/src/lib.rs

@@ -4,7 +4,6 @@
 use anyhow::{bail, Context, Result};
 use std::process::Command;
 
-/// Run `git fetch --depth=1 origin <base_ref>` to ensure the base ref is available locally.
 pub fn fetch_base(base_ref: &str) -> Result<()> {
     log::info!("Fetching base branch: {base_ref}");
 
@@ -18,16 +17,12 @@ pub fn fetch_base(base_ref: &str) -> Result<()> {
         .context("Failed to run git fetch")?;
 
     if !status.success() {
-        // Non-fatal: warn but do not abort (mirrors `|| true` in the bash version)
         log::warn!("git fetch for {base_ref} returned non-zero exit code; continuing");
     }
 
     Ok(())
 }
 
-/// Return the list of files changed between `origin/<base_ref>...HEAD` (three-dot diff).
-///
-/// Uses `git diff --name-only origin/<base_ref>...HEAD`.
 pub fn changed_files(base_ref: &str) -> Result<Vec<String>> {
     let output = Command::new("git")
         .args(["diff", "--name-only", &format!("origin/{base_ref}...HEAD")])

.github/actions/ci-shared/Cargo.toml

@@ -3,3 +3,5 @@
 
 pub mod crate_detection;
 pub mod github_output;
+pub mod git;
+pub mod workspace;

.github/actions/ci-crates/src/git.rs .github/actions/ci-shared/src/git.rs.github/actions/ci-crates/src/git.rs renamed to .github/actions/ci-shared/src/git.rs

@@ -9,7 +9,6 @@ use std::collections::{HashMap, HashSet, VecDeque};
 /// Parsed workspace metadata with reverse-dependency index.
 pub struct WorkspaceMetadata {
     packages: Vec<Package>,
-    /// Maps each crate name to the list of workspace crates that depend on it.
     reverse_deps: HashMap<String, Vec<String>>,
     workspace_root: Utf8PathBuf,
 }
@@ -105,8 +104,6 @@ mod tests {
         s.iter().map(|s| s.to_string()).collect()
     }
 
-    // --- affected_from ---
-
     #[test]
     fn affected_from_empty_seeds_returns_empty() {
         let meta = make_meta(&[]);
@@ -171,8 +168,6 @@ mod tests {
         );
     }
 
-    // --- load() integration ---
-
     #[test]
     fn load_returns_non_empty_workspace() {
         let meta = load().expect("load() should succeed against the real workspace");

.github/actions/ci-shared/src/lib.rs

@@ -7,7 +7,7 @@
 //! including finding existing comments and updating or creating comments.
 
 use anyhow::{Context as _, Result};
-use log::{error, info};
+use log::info;
 use octocrab::Octocrab;
 
 /// Post or update a comment on a PR with the given report

…ithub/actions/ci-crates/src/workspace.rs …ithub/actions/ci-shared/src/workspace.rs.github/actions/ci-crates/src/workspace.rs renamed to .github/actions/ci-shared/src/workspace.rs .github/actions/ci-crates/src/workspace.rs renamed to .github/actions/ci-shared/src/workspace.rs

@@ -2,16 +2,15 @@
 # SPDX-License-Identifier: Apache-2.0
 
 [package]
-name = "ci-crates"
+name = "crates-reporter"
 version = "0.1.0"
 edition = "2021"
 rust-version = "1.84.1"
+description = "GitHub Action for reporting modified crates and transitive dependencies"
+homepage = "https://github.com/DataDog/libdatadog/tree/main/.github/actions/changed-crates"
+repository = "https://github.com/DataDog/libdatadog/tree/main/.github/actions/changed-crates"
 publish = false
 
-[[bin]]
-name = "changed-crates"
-path = "src/bin/changed_crates.rs"
-
 [dependencies]
 ci-shared = { path = "../ci-shared" }
 anyhow = "1.0"

.github/actions/clippy-annotation-reporter/src/commenter.rs

@@ -45,7 +45,7 @@ runs:
       shell: bash
       run: |
         cd ${{ github.action_path }}/..
-        cargo build --release -p ci-crates
+        cargo build --release -p crates-reporter
 
     - name: Run change reporter
       id: detect
@@ -58,7 +58,7 @@ runs:
           echo "status=skipped" >> $GITHUB_OUTPUT
           exit 0
         fi
-        if RUST_LOG=debug ${{ github.action_path }}/../target/release/changed-crates $PR_BASE_REF; then
+        if RUST_LOG=debug ${{ github.action_path }}/../target/release/crates-reporter $PR_BASE_REF; then
           echo "status=success" >> $GITHUB_OUTPUT
         else
           echo "status=skipped" >> $GITHUB_OUTPUT