Try fixing ubsan

Author: gleocadie

profiler/src/ProfilerEngine/Datadog.Profiler.Native.Linux/CMakeLists.txt

@@ -30,14 +30,7 @@ if (RUN_ASAN)
 endif()
 
 if (RUN_UBSAN)
-    add_compile_options(-fsanitize=undefined -g -fno-omit-frame-pointer -fno-sanitize-recover=all -DDD_SANITIZERS)
-    if (ISARM64)
-        # On arm64, the CLR exports typeinfo for ProfToEEInterfaceImpl, so UBSAN's vptr
-        # check fires on every call through CLR interface pointers.  Suppress vptr checks
-        # only for CLR COM types (IUnknown, ICorProfilerInfo*, ICorProfilerCallback*).
-        # On x86_64 the CLR doesn't export that typeinfo, so the check is silently skipped.
-        add_compile_options(-fsanitize-ignorelist=${CMAKE_SOURCE_DIR}/profiler/src/ProfilerEngine/ubsan_ignorelist.txt)
-    endif()
+    add_compile_options(-fsanitize=undefined -g -fno-omit-frame-pointer -DDD_SANITIZERS)
 endif()
 
 if (RUN_TSAN)

profiler/src/ProfilerEngine/Datadog.Profiler.Native/CorProfilerCallback.cpp

@@ -1121,6 +1121,12 @@ ULONG STDMETHODCALLTYPE CorProfilerCallback::GetRefCount() const
     return refCount;
 }
 
+// On arm64, the CLR exports typeinfo for ProfToEEInterfaceImpl, so UBSAN's vptr
+// check fires on calls through COM interface pointers.  On x86_64 the CLR does
+// not export that typeinfo, so the check is silently skipped.
+#if defined(__clang__) && defined(ARM64)
+__attribute__((no_sanitize("vptr")))
+#endif
 void CorProfilerCallback::InspectRuntimeCompatibility(IUnknown* corProfilerInfoUnk, uint16_t& runtimeMajor, uint16_t& runtimeMinor)
 {
     runtimeMajor = 0;
@@ -1305,6 +1311,9 @@ void CorProfilerCallback::InspectProcessorInfo()
 #endif
 }
 
+#if defined(__clang__) && defined(ARM64)
+__attribute__((no_sanitize("vptr")))
+#endif
 void CorProfilerCallback::InspectRuntimeVersion(ICorProfilerInfo5* pCorProfilerInfo, USHORT& major, USHORT& minor, COR_PRF_RUNTIME_TYPE& runtimeType)
 {
     USHORT clrInstanceId;
@@ -1399,6 +1408,9 @@ void CorProfilerCallback::PrintEnvironmentVariables()
 const uint32_t InformationalVerbosity = 4;
 const uint32_t VerboseVerbosity = 5;
 
+#if defined(__clang__) && defined(ARM64)
+__attribute__((no_sanitize("vptr")))
+#endif
 HRESULT STDMETHODCALLTYPE CorProfilerCallback::Initialize(IUnknown* corProfilerInfoUnk)
 {
     Log::Info("CorProfilerCallback is initializing.");

profiler/src/ProfilerEngine/ubsan_ignorelist.txt

@@ -18,7 +18,7 @@ if (RUN_ASAN)
 endif()
 
 if (RUN_UBSAN)
-    add_compile_options(-fsanitize=undefined -g -fno-omit-frame-pointer -fno-sanitize-recover=all)
+    add_compile_options(-fsanitize=undefined -g -fno-omit-frame-pointer)
 endif()
 
 if(ISLINUX)

profiler/test/Datadog.Linux.ApiWrapper.Tests/CMakeLists.txt

@@ -22,7 +22,7 @@ if (RUN_ASAN)
 endif()
 
 if (RUN_UBSAN)
-    add_compile_options(-fsanitize=undefined -g -fno-omit-frame-pointer -fno-sanitize-recover=all)
+    add_compile_options(-fsanitize=undefined -g -fno-omit-frame-pointer)
 endif()
 
 if (RUN_TSAN)