Fixed events not being registered properly when changed in the inspector

Author: DanielEverland

Assets/GameEvent.asset

@@ -0,0 +1,15 @@
+%YAML 1.1
+%TAG !u! tag:unity3d.com,2011:
+--- !u!114 &11400000
+MonoBehaviour:
+  m_ObjectHideFlags: 0
+  m_CorrespondingSourceObject: {fileID: 0}
+  m_PrefabInternal: {fileID: 0}
+  m_GameObject: {fileID: 0}
+  m_Enabled: 1
+  m_EditorHideFlags: 0
+  m_Script: {fileID: 11500000, guid: 7a78c7052899406438e9fc79486b45c0, type: 3}
+  m_Name: GameEvent
+  m_EditorClassIdentifier: 
+  DeveloperDescription:
+    _value: 

Assets/GameEvent.asset.meta

@@ -0,0 +1,16 @@
+%YAML 1.1
+%TAG !u! tag:unity3d.com,2011:
+--- !u!114 &11400000
+MonoBehaviour:
+  m_ObjectHideFlags: 0
+  m_CorrespondingSourceObject: {fileID: 0}
+  m_PrefabInternal: {fileID: 0}
+  m_GameObject: {fileID: 0}
+  m_Enabled: 1
+  m_EditorHideFlags: 0
+  m_Script: {fileID: 11500000, guid: 8ea29b4887d65ef45a35c9c5add9005e, type: 3}
+  m_Name: IntGameEvent
+  m_EditorClassIdentifier: 
+  DeveloperDescription:
+    _value: 
+  _debugValue: 64

Assets/IntGameEvent.asset

@@ -0,0 +1,15 @@
+using System.Collections;
+using System.Collections.Generic;
+using UnityEngine;
+
+public class NewBehaviourScript : MonoBehaviour
+{
+    public void Raise(object value)
+    {
+        Debug.Log(value);
+    }
+    public void Raise()
+    {
+        Debug.Log("gfdkjh");
+    }
+}

Assets/IntGameEvent.asset.meta

@@ -13,8 +13,8 @@ public class TypedGameEventEditor : BaseGameEventEditor
     protected override void OnEnable()
     {
         base.OnEnable();
-
-        _raiseMethod = target.GetType().BaseType.GetMethod("Raise");
+        
+        _raiseMethod = target.GetType().BaseType.GetMethod("Raise", BindingFlags.DeclaredOnly | BindingFlags.Instance | BindingFlags.Public);
     }
     protected override void DrawRaiseButton()
     {

Assets/NewBehaviourScript.cs

@@ -1,42 +1,33 @@
 using UnityEngine;
 using System.Collections.Generic;
 
-public abstract class GameEventBase<T> : SOArchitectureBaseObject, IGameEvent<T>, IStackTraceObject
+public abstract class GameEventBase<T> : GameEventBase, IGameEvent<T>, IStackTraceObject
 {
-    private readonly List<IGameEventListener<T>> _listeners = new List<IGameEventListener<T>>();
-
-    public List<StackTraceEntry> StackTraces { get { return _stackTraces; } }
-    private List<StackTraceEntry> _stackTraces = new List<StackTraceEntry>();
+    private readonly List<IGameEventListener<T>> _typedListeners = new List<IGameEventListener<T>>();
 
 #if UNITY_EDITOR
     [SerializeField]
     protected T _debugValue;
-
-    public void AddStackTrace()
-    {
-        _stackTraces.Insert(0, StackTraceEntry.Create());
-    }
-    public void AddStackTrace(object value)
-    {
-        _stackTraces.Insert(0, StackTraceEntry.Create(value));
-    }
 #endif
     public void Raise(T value)
     {
         AddStackTrace(value);
 
+        for (int i = _typedListeners.Count - 1; i >= 0; i--)
+            _typedListeners[i].OnEventRaised(value);
+
         for (int i = _listeners.Count - 1; i >= 0; i--)
-            _listeners[i].OnEventRaised(value);
+            _listeners[i].OnEventRaised();
     }
     public void AddListener(IGameEventListener<T> listener)
     {
-        if (!_listeners.Contains(listener))
-            _listeners.Add(listener);
+        if (!_typedListeners.Contains(listener))
+            _typedListeners.Add(listener);
     }
     public void RemoveListener(IGameEventListener<T> listener)
     {
-        if (_listeners.Contains(listener))
-            _listeners.Remove(listener);
+        if (_typedListeners.Contains(listener))
+            _typedListeners.Remove(listener);
     }
     public override string ToString()
     {
@@ -45,7 +36,7 @@ public override string ToString()
 }
 public abstract class GameEventBase : SOArchitectureBaseObject, IGameEvent, IStackTraceObject
 {
-    private readonly List<IGameEventListener> _listeners = new List<IGameEventListener>();
+    protected readonly List<IGameEventListener> _listeners = new List<IGameEventListener>();
 
     public List<StackTraceEntry> StackTraces { get { return _stackTraces; } }
     private List<StackTraceEntry> _stackTraces = new List<StackTraceEntry>();

Assets/NewBehaviourScript.cs.meta

@@ -13,6 +13,8 @@ public abstract class BaseGameEventListener<TType, TEvent, TResponse> : Debuggab
     protected override ScriptableObject GameEvent { get { return _event; } }
     protected override UnityEventBase Response { get { return _response; } }
 
+    [SerializeField]
+    private TEvent _previouslyRegisteredEvent;
     [SerializeField]
     private TEvent _event;
     [SerializeField]
@@ -35,16 +37,31 @@ private void RaiseResponse(TType value)
     {
         _response.Invoke(value);
     }
+    private void OnValidate()
+    {
+        if (_event != null)
+            Register();
+    }
     private void OnEnable()
     {
         if (_event != null)
-            _event.AddListener(this);
+            Register();
     }
     private void OnDisable()
     {
         if (_event != null)
             _event.RemoveListener(this);
     }
+    private void Register()
+    {
+        if(_previouslyRegisteredEvent != null)
+        {
+            _previouslyRegisteredEvent.RemoveListener(this);
+        }
+
+        _event.AddListener(this);
+        _previouslyRegisteredEvent = _event;
+    }
 }
 public abstract class BaseGameEventListener<TEvent, TResponse> : DebuggableGameEventListener, IGameEventListener
     where TEvent : GameEventBase
@@ -53,6 +70,8 @@ public abstract class BaseGameEventListener<TEvent, TResponse> : DebuggableGameE
     protected override ScriptableObject GameEvent { get { return _event; } }
     protected override UnityEventBase Response { get { return _response; } }
 
+    [SerializeField]
+    private TEvent _previouslyRegisteredEvent;
     [SerializeField]
     private TEvent _event;
     [SerializeField]
@@ -70,16 +89,31 @@ protected void RaiseResponse()
     {
         _response.Invoke();
     }
+    private void OnValidate()
+    {
+        if (_event != null)
+            Register();
+    }
     private void OnEnable()
     {
         if (_event != null)
-            _event.AddListener(this);
+            Register();
     }
     private void OnDisable()
     {
         if (_event != null)
             _event.RemoveListener(this);
     }
+    private void Register()
+    {
+        if (_previouslyRegisteredEvent != null)
+        {
+            _previouslyRegisteredEvent.RemoveListener(this);
+        }
+
+        _event.AddListener(this);
+        _previouslyRegisteredEvent = _event;
+    }
 }
 public abstract class DebuggableGameEventListener : SOArchitectureBaseMonobehaviour, IStackTraceObject
 {