Skip to content

Commit 1775dac

Browse files
authored
Merge pull request #8424 from chrisburr/fix/singularity-memory-limit-type
fix: Convert MemoryLimitMB to int before comparison in SingularityComputingElement
2 parents 1304ce5 + 7814c0a commit 1775dac

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/DIRAC/Resources/Computing/SingularityComputingElement.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -421,7 +421,7 @@ def submitJob(self, executableFile, proxy=None, **kwargs):
421421
# if there's a max RAM available to the job, use that
422422
if self.maxRAM:
423423
self.ceParameters["MemoryLimitMB"] = min(
424-
self.maxRAM, self.ceParameters.get("MemoryLimitMB", 1024 * 1024)
424+
self.maxRAM, int(self.ceParameters.get("MemoryLimitMB", 1024 * 1024))
425425
) # 1024 * 1024 is an arbitrary large number
426426
result = CG2Manager().systemCall(
427427
0, cmd, callbackFunction=self.sendOutput, env=self.__getEnv(), ceParameters=self.ceParameters

src/DIRAC/WorkloadManagementSystem/Utilities/JobParameters.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,7 @@ def getAvailableRAM(siteName=None, gridCE=None, queue=None):
242242
gLogger.info("Looking in", csPath)
243243
availableRAM = gConfig.getValue(csPath, None)
244244
if availableRAM:
245-
return availableRAM
245+
return int(availableRAM)
246246

247247
# 3) checks if 'WholeNode' is one of the used tags
248248
# Tags of the CE
@@ -277,6 +277,6 @@ def getRAMForJob(jobID):
277277
# from /Resources/Computing/JobLimits/jobID/MaxRAM (set by PoolComputingElement)
278278
ram = gConfig.getValue(f"Resources/Computing/JobLimits/{jobID}/MaxRAM")
279279
if ram:
280-
return ram
280+
return int(ram)
281281

282282
return getAvailableRAM()

0 commit comments

Comments
 (0)