Add map issue check for a difficulty-specific trigger disabling a trigger of a different difficulty level

Author: Rampastring

src/TSMapEditor/Config/Translations/en/Translation_en.ini

@@ -135,6 +135,7 @@ Map.CheckForIssues.TriggerTooManyActions=Trigger '{0}' has more than {1} actions
 Map.CheckForIssues.SpecialWaypointUsed=The map makes use of waypoint #{0}. In Tiberian Sun, this waypoint is reserved for special use cases (WAYPT_SPECIAL). Using it as a normal waypoint may cause issues as it may be dynamically moved by game events.
 Map.CheckForAITriggerTeamWithMaxZeroIssue.TeamTypeMax=Team '{0}', linked to AITrigger '{1}', has Max=0. This prevents the AI from building the team.
 Map.CheckForIssues.MismatchedDifficultyForEnableTrigger=The trigger "{0}" has "{1}" as its difficulty level, but it enables a trigger "{2}" which has "{3}" as its difficulty.
+Map.CheckForIssues.MismatchedDifficultyForDisableTrigger=The trigger "{0}" has "{1}" as its difficulty level, but it disables a trigger "{2}" which has "{3}" as its difficulty.
 
 ; *************************************************
 ;                    Difficulty

src/TSMapEditor/Misc/MapIssueChecker.cs

@@ -11,6 +11,7 @@ namespace TSMapEditor.Misc
     public static class MapIssueChecker
     {
         private const int EnableTriggerActionIndex = 53;
+        private const int DisableTriggerActionIndex = 54;
         private const int TriggerParamIndex = 1;
 
         /// <summary>
@@ -71,8 +72,6 @@ public static List<string> CheckForIssues(Map map)
                         "TeamType \"{0}\" has no Script set!"), tt.Name));
             });
 
-            const int DisableTriggerActionIndex = 54;
-
             // Check for triggers that are disabled and are never enabled by any other triggers
             map.Triggers.ForEach(trigger =>
             {
@@ -427,6 +426,7 @@ public static List<string> CheckForIssues(Map map)
             }
 
             CheckForMismatchedDifficultyEnableIssue(map, issueList);
+            CheckForMismatchedDifficultyDisableIssue(map, issueList);
 
             return issueList;
         }
@@ -522,5 +522,38 @@ private static void CheckForMismatchedDifficultyEnableIssue(Map map, List<string
                 }
             }
         }
+
+        private static void CheckForMismatchedDifficultyDisableIssue(Map map, List<string> issueList)
+        {
+            foreach (var trigger in map.Triggers)
+            {
+                Difficulty difficulty = GetTriggerDifficulty(map, trigger);
+
+                if (difficulty == Difficulty.None)
+                    continue;
+
+                // Check if this trigger disables a trigger that does not match its difficulty level.
+                // If yes, report that as a bug.
+                for (int i = 0; i < trigger.Actions.Count; i++)
+                {
+                    TriggerAction action = trigger.Actions[i];
+
+                    if (action.ActionIndex == DisableTriggerActionIndex)
+                    {
+                        var otherTrigger = map.Triggers.Find(t => t.ID == action.Parameters[TriggerParamIndex]);
+                        if (otherTrigger != null)
+                        {
+                            Difficulty otherTriggerDifficulty = GetTriggerDifficulty(map, otherTrigger);
+                            if (otherTriggerDifficulty != Difficulty.None && difficulty != otherTriggerDifficulty)
+                            {
+                                issueList.Add(string.Format(Translate(map, "CheckForIssues.MismatchedDifficultyForDisableTrigger",
+                                    "The trigger \"{0}\" has \"{1}\" as its difficulty level, but it disables a trigger \"{2}\" which has \"{3}\" as its difficulty."),
+                                    trigger.Name, Helpers.DifficultyToTranslatedString(difficulty), otherTrigger.Name, Helpers.DifficultyToTranslatedString(otherTriggerDifficulty)));
+                            }
+                        }
+                    }
+                }
+            }
+        }
     }
 }