You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I added a set of TODO's in ClimaLand, which should be addressed sequentially:
Replace compute_ρ_sfc by calls to surface_density from SurfaceFluxes.jl (once there's a new release)
Update derivative ∂ρsfc∂Tc to be consistent with new surface density calculation
Remove remaining calls to Thermodynamics.PhaseEquil_* in update to new SurfaceFluxes.jl (and replace to calls to functional Thermodynamics API)
Replace magic numbers by well-defined parameters (with names and dimensions); use parameters from ClimaParams wherever possible. For example, this code block contains a number (1370) that looks to be total solar irradiance, which should come from ClimaParams, as well as several hard-coded constants that are dimensional:
I added a set of TODO's in ClimaLand, which should be addressed sequentially:
compute_ρ_sfcby calls tosurface_densityfrom SurfaceFluxes.jl (once there's a new release)∂ρsfc∂Tcto be consistent with new surface density calculationThermodynamics.PhaseEquil_*in update to new SurfaceFluxes.jl (and replace to calls to functional Thermodynamics API)ClimaLand.jl/src/shared_utilities/drivers.jl
Lines 1675 to 1689 in d2b2b91