Conversation
nefrathenrici
approved these changes
Apr 13, 2026
Member
nefrathenrici
left a comment
nefrathenrici
left a comment
There was a problem hiding this comment.
Thank you, it's nice to finally change the initial iteration index from 0 to 1!
Keeping the manifest introduces unnecessary repository noise and busywork when updating dependencies.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #298 +/- ##
==========================================
+ Coverage 49.49% 53.67% +4.18%
==========================================
Files 16 16
Lines 1281 1291 +10
==========================================
+ Hits 634 693 +59
+ Misses 647 598 -49 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ph-kev
added a commit
that referenced
this pull request
Apr 15, 2026
These tests were missed in #298.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #294
This PR adds job status to be an enum instead of symbols, updates iteration indexing to one-based indexing, reorganize tests, and removes the Manifest.
The zero-based indexing was inconsistent with indexing used by Julia and EKP. Tests that doesn't involve using the backend are moved to GHA instead. Finally, the manifest was removed because leeping the manifest introduces unnecessary repository noise and busywork when updating dependencies.