lint issues fixed

Author: cx-anjali-deore

internal/services/applications.go

@@ -87,17 +87,18 @@ func findApplicationAndUpdate(applicationName string, applicationsWrapper wrappe
 	applicationModel.Tags = applicationResp.Tags
 	newApplicationRule.Type = ApplicationRuleType
 	newApplicationRule.Value = projectName
-	applicationModel.Rules = append(applicationResp.Rules, newApplicationRule)
+	combinedRules := append(applicationResp.Rules, newApplicationRule)
+	applicationModel.Rules = combinedRules
 	applicationID = applicationResp.ID
 
-	err = updateApplication(applicationModel, applicationsWrapper, applicationID)
+	err = updateApplication(&applicationModel, applicationsWrapper, applicationID)
 	if err != nil {
 		return err
 	}
 	return nil
 }
 
-func updateApplication(applicationModel wrappers.ApplicationConfiguration, applicationWrapper wrappers.ApplicationsWrapper, applicationID string) error {
+func updateApplication(applicationModel *wrappers.ApplicationConfiguration, applicationWrapper wrappers.ApplicationsWrapper, applicationID string) error {
 	errorModel, err := applicationWrapper.Update(applicationID, applicationModel)
 	if errorModel != nil {
 		err = errors.Errorf(ErrorCodeFormat, "failed to update application", errorModel.Code, errorModel.Message)

internal/wrappers/application-http.go

@@ -22,7 +22,7 @@ func NewApplicationsHTTPWrapper(path string) ApplicationsWrapper {
 	}
 }
 
-func (a *ApplicationsHTTPWrapper) Update(applicationID string, applicationBody ApplicationConfiguration) (*ErrorModel, error) {
+func (a *ApplicationsHTTPWrapper) Update(applicationID string, applicationBody *ApplicationConfiguration) (*ErrorModel, error) {
 	clientTimeout := viper.GetUint(commonParams.ClientTimeoutKey)
 	jsonBytes, err := json.Marshal(applicationBody)
 	updatePath := fmt.Sprintf("%s/%s", a.path, applicationID)
@@ -34,6 +34,10 @@ func (a *ApplicationsHTTPWrapper) Update(applicationID string, applicationBody A
 		return nil, err
 	}
 	decoder := json.NewDecoder(resp.Body)
+	defer func() {
+		_ = resp.Body.Close()
+	}()
+
 	switch resp.StatusCode {
 	case http.StatusBadRequest:
 		errorModel := ErrorModel{}

internal/wrappers/application.go

@@ -38,5 +38,5 @@ type Rule struct {
 
 type ApplicationsWrapper interface {
 	Get(params map[string]string) (*ApplicationsResponseModel, error)
-	Update(applicationID string, applicationBody ApplicationConfiguration) (*ErrorModel, error)
+	Update(applicationID string, applicationBody *ApplicationConfiguration) (*ErrorModel, error)
 }

internal/wrappers/mock/application-mock.go

@@ -50,18 +50,16 @@ func (a ApplicationsMockWrapper) Get(params map[string]string) (*wrappers.Applic
 		response.TotalCount = 0
 		response.Applications = []wrappers.Application{}
 	}
-
 	return response, nil
 }
 
-func (a ApplicationsMockWrapper) Update(applicationID string, applicationBody wrappers.ApplicationConfiguration) (*wrappers.ErrorModel, error) {
+func (a ApplicationsMockWrapper) Update(applicationID string, applicationBody *wrappers.ApplicationConfiguration) (*wrappers.ErrorModel, error) {
 	fmt.Println("called Update project")
 	if applicationID == FakeForbidden403 {
 		return nil, errors.Errorf(errorConstants.NoPermissionToUpdateApplication)
 	}
 	if applicationID == FakeUnauthorized401 {
 		return nil, errors.Errorf(errorConstants.StatusUnauthorized)
 	}
-
 	return nil, nil
 }