swap order of code blocks to prevent a null error when user is undefined (#574)

Author: danoswaltCL

backend/packages/Upgrade/src/api/services/ExperimentAssignmentService.ts

@@ -398,16 +398,8 @@ export class ExperimentAssignmentService {
       this.experimentUserService.getOriginalUserDoc(userId, logger)
     ]);
 
-    const experimentUser: ExperimentUser = userDoc || {
-      createdAt: experimentUserDoc.createdAt,
-      id: experimentUserDoc.id,
-      requestedUserId: userId,
-      group: experimentUserDoc.group,
-      workingGroup: experimentUserDoc.workingGroup
-    };
-
     // throw error if user not defined
-    if (!experimentUser) {
+    if (!experimentUserDoc || !experimentUserDoc.id) {
       logger.error({ message: `User not defined in getAllExperimentConditions: ${userId}` });
       let error = new Error(
         JSON.stringify({
@@ -420,6 +412,14 @@ export class ExperimentAssignmentService {
       throw error;
     }
 
+    const experimentUser: ExperimentUser = userDoc || {
+      createdAt: experimentUserDoc.createdAt,
+      id: experimentUserDoc.id,
+      requestedUserId: userId,
+      group: experimentUserDoc.group,
+      workingGroup: experimentUserDoc.workingGroup
+    };
+
     // query all experiment and sub experiment
     // check if user or group is excluded
     let experiments: Experiment[] = [], userExcluded: string, groupExcluded: string[];