When the player is in a fluid of "The Bumblezone" mods, some chunks are not rendered

[Lolothepro]

Bug Description

When the player is in a fluid of "The Bumblezone" mods, some chunks are not rendered.

2024-03-09.18-25-46.mp4

Reproduction Steps

1. Install "The Bumblezone" mod
2. Install Indium
3. Go into honey with a honey bucket
4. Notice that some chunks disappear

Log File

https://mclo.gs/jCbZqLY

Crash Report

https://mclo.gs/jCbZqLY

[jellysquid3]

This is likely because the alpha value of the fog color is not fully opaque. We should check that we don't set a near fog distance in chunk rendering if that's the case.

[Adidiii]

Could this also be caused by culling?

[contariaa]

This is likely because the alpha value of the fog color is not fully opaque. We should check that we don't set a near fog distance in chunk rendering if that's the case.

Disabling Fog Occlusion culling does fix this issue, however unless I'm misunderstanding fog color doesn't seem to be the problem here, this is the solution I tried (and didn't work):

1.21.1:

float fogDistance;
if (RenderSystem.getShaderFogColor()[3] == 1.0f) {
    fogDistance = RenderSystem.getShaderFogEnd();
} else {
    fogDistance = Float.MAX_VALUE;
}

1.21.4:

float fogDistance;
if (RenderSystem.getShaderFog().alpha() == 1.0f) {
    fogDistance = RenderSystem.getShaderFog().end();
} else {
    fogDistance = Float.MAX_VALUE;
}

From my testing the fog color inside the honey fluid has an alpha value of 1.0, these are the values I found (the_bumblezone-7.8.9+1.21.1-fabric.jar):

color[0]=0,522667, color[1]=0,261333, color[2]=0,000000, color[3]=1,000000, start=0,350000, end=4,000000

using

System.out.printf(
    "color[0]=%f, color[1]=%f, color[2]=%f, color[3]=%f, color[0]=%f, color[1]=%f, color[2]=%f, color[3]=%f, start=%f, end=%f\n",
    RenderSystem.getShaderFogColor()[0],
    RenderSystem.getShaderFogColor()[1],
    RenderSystem.getShaderFogColor()[2],
    RenderSystem.getShaderFogColor()[3],
    RenderSystem.getShaderFogStart(),
    RenderSystem.getShaderFogEnd()
);

[jellysquid3]

At some point, Sodium's occlusion culling code began to evaluate the fog's distance and the render distance as a single value. If the fog's end point was closer than the render distance limit, it was used instead (code.) But this looks like it should avoid the problem, unless Bumblezone is setting the fog to a different value later on?