run rubocop

Author: corymosiman12

buildingsync.gemspec

@@ -26,9 +26,9 @@ Gem::Specification.new do |spec|
   spec.required_ruby_version = '~> 2.5.0'
 
   spec.add_dependency 'bundler', '~> 2.1'
-  spec.add_dependency 'openstudio-extension', '~> 0.2.6'
   spec.add_dependency 'openstudio-common-measures', '~> 0.2.0'
   spec.add_dependency 'openstudio-ee', '~> 0.2.0'
+  spec.add_dependency 'openstudio-extension', '~> 0.2.6'
   spec.add_dependency 'openstudio-model-articulation', '~> 0.2.0'
   spec.add_dependency 'openstudio-standards', '~> 0.2.11'
 

lib/buildingsync/get_bcl_weather_file.rb

@@ -52,15 +52,15 @@ def initialize
       FileUtils.mkdir_p(@weather_file_path_prefix)
       if File.exist?(@weather_file)
         File.open(@weather_file, 'r') do |file|
-          @weather_json = JSON.parse(file.read, {:symbolize_names => true})
+          @weather_json = JSON.parse(file.read, symbolize_names: true)
         end
       else
         arr = []
         @weather_json = {
-            'weather_file_name': arr,
-            'city_name': arr,
-            'state_code': arr,
-            'weather_id': arr
+          'weather_file_name': arr,
+          'city_name': arr,
+          'state_code': arr,
+          'weather_id': arr
         }
         File.open(@weather_file, 'w') { |f| f.write(@weather_json.to_json) }
       end

lib/buildingsync/helpers/xml_get_set.rb

@@ -44,15 +44,14 @@ module BuildingSync
   # Used for getting, setting, and creating XML snippets
   # for BuildingSync classes with an @base_xml attribute
   module XmlGetSet
-    
     def get_prefix
       if @ns == ''
         return ''
       else
         return "#{@ns}:"
       end
     end
-    
+
     # Get the id attribute of the @base_xml
     # @see help_get_attribute_value
     def xget_id

lib/buildingsync/makers/workflow_maker.rb

@@ -312,7 +312,7 @@ def configure_workflow_for_scenario(base_workflow, scenario)
           # in the BuildingSync Schema, a <MeasureName>Other</MeasureName> is used
           # and the actual measure name added
           if m_name == :Other
-            m_name = measure.xget_text("CustomMeasureName")
+            m_name = measure.xget_text('CustomMeasureName')
             if m_name.nil? || m_name.empty?
               OpenStudio.logFree(OpenStudio::Warn, 'BuildingSync.WorkflowMaker.configure_workflow_for_scenario', "Measure ID: #{measure.xget_id} has a MeasureName of 'Other' but does not have a CustomMeasureName defined.")
               successful = false
@@ -322,15 +322,13 @@ def configure_workflow_for_scenario(base_workflow, scenario)
           end
           measure_found = false
           @workflow_maker_json[sym_to_find].each do |category|
-
             # m_name is, for example: 'Replace HVAC system type to VRF'
 
             if !category[m_name].nil?
               measure_found = true
               measure_dir_name = category[m_name][:measure_dir_name]
               num_measures += 1
               category[m_name][:arguments].each do |argument|
-
                 # Certain arguments are only applied under specific conditions
                 #
                 if !argument[:condition].nil? && !argument[:condition].empty?
@@ -397,7 +395,7 @@ def set_argument_detail(workflow, argument, measure_dir_name, measure_name)
         end
       elsif measure_name == 'Replace HVAC system type to VRF' || measure_name == 'Replace HVAC with GSHP and DOAS' || measure_name == 'Replace AC and heating units with ground coupled heat pump systems'
         if argument[:condition] == @facility.site.get_building_type
-          argument_name = "#{argument[:name]}"
+          argument_name = (argument[:name]).to_s
           argument_value = argument[:value]
         end
       else
@@ -432,7 +430,7 @@ def write_osws(main_output_dir, only_cb_modeled = false)
 
       number_successful = cb_modeled_success ? 1 : 0
 
-      if not only_cb_modeled
+      if !only_cb_modeled
         # write an osw for each Package Of Measures scenario
         @facility.report.poms.each do |scenario|
           successful = write_osw(main_output_dir, scenario)
@@ -444,7 +442,6 @@ def write_osws(main_output_dir, only_cb_modeled = false)
         end
       end
 
-
       # Compare the total number of potential successes to the number of actual successes
       if only_cb_modeled
         # In this case we should have only 1 success
@@ -496,7 +493,7 @@ def write_osw(main_output_dir, scenario)
     # run osws - running all scenario simulations
     # @param only_cb_modeled [Boolean] used to only run the simulations for the cb_modeled (baseline) scenario
     # @param runner_options [hash]
-    def run_osws(output_dir, only_cb_modeled = false, runner_options = {run_simulations: true, verbose: false, num_parallel: 7, max_to_run: Float::INFINITY})
+    def run_osws(output_dir, only_cb_modeled = false, runner_options = { run_simulations: true, verbose: false, num_parallel: 7, max_to_run: Float::INFINITY })
       osw_files = []
       osw_sr_files = []
       if only_cb_modeled

lib/buildingsync/model_articulation/building.rb

@@ -225,7 +225,6 @@ def get_building_type
       end
     end
 
-
     # get full path to epw file
     # return [String]
     def get_epw_file_path
@@ -551,7 +550,7 @@ def set_weather_and_climate_zone(climate_zone, epw_file_path, standard_to_be_use
         weather_station_id = weather_argb[1]
         state_name = weather_argb[2]
         city_name = weather_argb[3]
-        puts "case 2: climate_zone is nil at the Site and Building level"
+        puts 'case 2: climate_zone is nil at the Site and Building level'
         if !weather_station_id.nil?
           puts "case 2.1: weather_station_id is not nil #{weather_station_id}"
           @epw_file_path = BuildingSync::GetBCLWeatherFile.new.download_weather_file_from_weather_id(weather_station_id)

lib/buildingsync/model_articulation/facility.rb

@@ -189,7 +189,7 @@ def get_epw_file_path
     def get_auditor_contact_name
       auditor_id = @report.get_auditor_contact_id
       if !auditor_id.nil?
-        contact = @contacts.find { |contact| contact.xget_id == auditor_id}
+        contact = @contacts.find { |contact| contact.xget_id == auditor_id }
         return contact.xget_text('ContactName')
       end
       return nil
@@ -233,7 +233,7 @@ def read_and_create_initial_systems
     end
 
     # @see BuildingSync::Report.add_cb_modeled
-    def add_cb_modeled(id = "Scenario-Baseline")
+    def add_cb_modeled(id = 'Scenario-Baseline')
       @report.add_cb_modeled(id)
     end
 

lib/buildingsync/model_articulation/hvac_system.rb

@@ -58,11 +58,9 @@ def initialize(base_xml, ns = 'auc')
     end
 
     # read xml
-    def read_xml;
-    end
+    def read_xml; end
 
-    def get_linked_ids;
-    end
+    def get_linked_ids; end
 
     # get principal hvac system type
     # @return [String]
@@ -137,7 +135,6 @@ def add_thermostats(model, standard, remove_objects)
             space.thermalZone.get.setThermostatSetpointDualSetpoint(thermostat)
           end
         end
-
       end
       puts "ThermalZones: #{model.getThermalZones.size}"
       puts "ThermostatDSPs: #{model.getThermostatSetpointDualSetpoints.size}"
@@ -164,16 +161,16 @@ def add_setpoints_to_thermostats_if_none(model)
       puts "BuildingSync.HVACSystem.add_setpoints_to_thermostats_if_none - (#{tstats_heating.size}) thermostats needing heating schedule"
 
       htg_setpoints = [
-          # [Time.new(days, hours, mins seconds), temp_value_celsius]
-          [OpenStudio::Time.new(0, 9, 0, 0), 17],
-          [OpenStudio::Time.new(0, 17, 0, 0), 20],
-          [OpenStudio::Time.new(0, 24, 0, 0), 17]
+        # [Time.new(days, hours, mins seconds), temp_value_celsius]
+        [OpenStudio::Time.new(0, 9, 0, 0), 17],
+        [OpenStudio::Time.new(0, 17, 0, 0), 20],
+        [OpenStudio::Time.new(0, 24, 0, 0), 17]
       ]
       clg_setpoints = [
-          # [Time.new(days, hours, mins seconds), temp_value_celsius]
-          [OpenStudio::Time.new(0, 9, 0, 0), 23],
-          [OpenStudio::Time.new(0, 17, 0, 0), 20],
-          [OpenStudio::Time.new(0, 24, 0, 0), 23]
+        # [Time.new(days, hours, mins seconds), temp_value_celsius]
+        [OpenStudio::Time.new(0, 9, 0, 0), 23],
+        [OpenStudio::Time.new(0, 17, 0, 0), 20],
+        [OpenStudio::Time.new(0, 24, 0, 0), 23]
       ]
 
       heating_sp_schedule = create_schedule_ruleset(model, htg_setpoints, 'Thermostat Heating SP')

lib/buildingsync/model_articulation/loads_system.rb

@@ -283,6 +283,5 @@ def add_elevator(model, standard)
       end
       return true
     end
-
   end
 end

lib/buildingsync/report.rb

@@ -160,8 +160,8 @@ def get_first_benchmark_site_eui
       end
       if eui.size == 1
         return eui[0]
-      elsif eui.size == 0
-        OpenStudio.logFree(OpenStudio::Warn, 'BuildingSync.Facility.get_benchmark_site_eui', "No Benchmark Scenarios exist with SiteEnergyUseIntensity defined")
+      elsif eui.empty?
+        OpenStudio.logFree(OpenStudio::Warn, 'BuildingSync.Facility.get_benchmark_site_eui', 'No Benchmark Scenarios exist with SiteEnergyUseIntensity defined')
         return nil
       elsif eui.size > 1
         OpenStudio.logFree(OpenStudio::Warn, 'BuildingSync.Facility.get_benchmark_site_eui', "Multiple Benchmark Scenarios exist with SiteEnergyUseIntensity defined. Returning the value for Scenario ID: #{ids[0]}")
@@ -187,7 +187,7 @@ def get_first_scenario_site_eui(scenario)
       end
       if eui.size == 1
         return eui[0]
-      elsif eui.size == 0
+      elsif eui.empty?
         OpenStudio.logFree(OpenStudio::Warn, 'BuildingSync.Facility.get_scenario_site_eui', "Scenario ID: #{@cb_modeled.xget_id} does not have a SiteEnergyUseIntensity defined in any of the AllResourceTotal elements.")
         return nil
       elsif eui.size > 1
@@ -199,7 +199,7 @@ def get_first_scenario_site_eui(scenario)
     # add a current building modeled scenario and set the @cb_modeled attribute
     # @param id [String] id to use for the scenario
     # @return [NilClass]
-    def add_cb_modeled(id = "Scenario-Baseline")
+    def add_cb_modeled(id = 'Scenario-Baseline')
       if @cb_modeled.nil? || @cb_modeled.empty?
         g = BuildingSync::Generator.new
         scenario_xml = g.add_scenario_to_report(@base_xml, 'CBModeled', id)

lib/buildingsync/translator.rb

@@ -103,17 +103,16 @@ def initialize(xml_file_path, output_dir, epw_file_path = nil, standard_to_be_us
     # using the SelectionTool
     def validate_xml
       # we wil try to validate the file, but if it fails, we will not cancel the process, but log an error
-      begin
-        selection_tool = BuildingSync::SelectionTool.new(@xml_file_path, @schema_version)
-        if !selection_tool.validate_schema
-          raise "File '#{@xml_file_path}' does not valid against the BuildingSync schema"
-        else
-          OpenStudio.logFree(OpenStudio::Info, 'BuildingSync.Translator.initialize', "File '#{@xml_file_path}' is valid against the BuildingSync schema")
-          puts "File '#{@xml_file_path}' is valid against the BuildingSync schema"
-        end
-      rescue StandardError
-        OpenStudio.logFree(OpenStudio::Error, 'BuildingSync.Translator.initialize', "File '#{@xml_file_path}' does not valid against the BuildingSync schema")
+
+      selection_tool = BuildingSync::SelectionTool.new(@xml_file_path, @schema_version)
+      if !selection_tool.validate_schema
+        raise "File '#{@xml_file_path}' does not valid against the BuildingSync schema"
+      else
+        OpenStudio.logFree(OpenStudio::Info, 'BuildingSync.Translator.initialize', "File '#{@xml_file_path}' is valid against the BuildingSync schema")
+        puts "File '#{@xml_file_path}' is valid against the BuildingSync schema"
       end
+    rescue StandardError
+      OpenStudio.logFree(OpenStudio::Error, 'BuildingSync.Translator.initialize', "File '#{@xml_file_path}' does not valid against the BuildingSync schema")
     end
 
     # @see WorkflowMaker.setup_and_sizing_run
@@ -137,7 +136,7 @@ def gather_results(year_val = Date.today.year, baseline_only = false)
 
     # run osws - running all scenario simulations
     # @param runner_options [hash]
-    def run_osws(only_cb_modeled = false, runner_options = {run_simulations: true, verbose: false, num_parallel: 7, max_to_run: Float::INFINITY})
+    def run_osws(only_cb_modeled = false, runner_options = { run_simulations: true, verbose: false, num_parallel: 7, max_to_run: Float::INFINITY })
       super(@output_dir, only_cb_modeled, runner_options)
     end
 
@@ -146,7 +145,7 @@ def prepare_final_xml
       if @results_gathered
         super
       else
-        OpenStudio.logFree(OpenStudio::Info, 'BuildingSync.Translator.prepare_final_xml', "All results have not yet been gathered.")
+        OpenStudio.logFree(OpenStudio::Info, 'BuildingSync.Translator.prepare_final_xml', 'All results have not yet been gathered.')
         super
       end
       @final_xml_prepared = true