chore: fix clippy errors and bump version to 1.2.0

- Remove redundant imports (shellexpand, dirs)
- Collapse nested if statements for better readability
- Replace .get(0) with .first()
- Remove unnecessary borrows in args()
- Use flatten() instead of manual if let pattern

Author: BreathCodeFlow

Cargo.lock

@@ -1,6 +1,6 @@
 [package]
 name = "tide"
-version = "1.1.0"
+version = "1.2.0"
 edition = "2021"
 authors = ["Markus Sommer"]
 description = "🌊 Tide - Refresh your system with the update wave"

Cargo.toml

@@ -2,7 +2,6 @@ use anyhow::{Context, Result};
 use colored::Colorize;
 use dialoguer::{theme::ColorfulTheme, Confirm, Password};
 use indicatif::{MultiProgress, ProgressBar, ProgressStyle};
-use shellexpand;
 use std::path::Path;
 use std::process::{Command, Stdio};
 use std::sync::Arc;
@@ -124,18 +123,17 @@ impl TaskExecutor {
         }
 
         // Optionally save password into keychain
-        if !keychain::entry_exists(keychain_label) {
-            if Confirm::with_theme(&ColorfulTheme::default())
+        if !keychain::entry_exists(keychain_label)
+            && Confirm::with_theme(&ColorfulTheme::default())
                 .with_prompt("Save password to keychain for future use?")
                 .default(true)
                 .interact()?
-            {
-                keychain::save_password(keychain_label, &password)?;
-                println!(
-                    "{}",
-                    "✓ Password saved to keychain (service: tide-sudo)".green()
-                );
-            }
+        {
+            keychain::save_password(keychain_label, &password)?;
+            println!(
+                "{}",
+                "✓ Password saved to keychain (service: tide-sudo)".green()
+            );
         }
 
         Ok(())
@@ -253,7 +251,7 @@ impl TaskExecutor {
         }
 
         // Execute command
-        let result = if cmd.get(0).map(|s| s.as_str()) == Some("sudo") {
+        let result = if cmd.first().map(|s| s.as_str()) == Some("sudo") {
             self.run_sudo_command(&cmd[1..], keychain_label).await
         } else {
             self.run_command(&cmd, &task, &task_name, &group_name).await
@@ -412,14 +410,13 @@ impl TaskExecutor {
         }
 
         // 4. Optionally save password into keychain
-        if !keychain::entry_exists(keychain_label) {
-            if Confirm::with_theme(&ColorfulTheme::default())
+        if !keychain::entry_exists(keychain_label)
+            && Confirm::with_theme(&ColorfulTheme::default())
                 .with_prompt("Save password to keychain for future use?")
                 .default(true)
                 .interact()?
-            {
-                keychain::save_password(keychain_label, &password)?;
-            }
+        {
+            keychain::save_password(keychain_label, &password)?;
         }
 
         run_actual(args)

src/executor.rs

@@ -4,7 +4,7 @@ use std::process::{Command, Stdio};
 /// Check if a keychain entry exists
 pub fn entry_exists(label: &str) -> bool {
     Command::new("security")
-        .args(&["find-generic-password", "-s", label, "-a", "root"])
+        .args(["find-generic-password", "-s", label, "-a", "root"])
         .stdout(Stdio::null())
         .stderr(Stdio::null())
         .status()
@@ -15,7 +15,7 @@ pub fn entry_exists(label: &str) -> bool {
 /// Get password from keychain
 pub fn get_password(label: &str) -> Result<String> {
     let output = Command::new("security")
-        .args(&["find-generic-password", "-s", label, "-a", "root", "-w"])
+        .args(["find-generic-password", "-s", label, "-a", "root", "-w"])
         .output()?;
 
     if output.status.success() {
@@ -28,7 +28,7 @@ pub fn get_password(label: &str) -> Result<String> {
 /// Save password to keychain
 pub fn save_password(label: &str, password: &str) -> Result<()> {
     let status = Command::new("security")
-        .args(&[
+        .args([
             "add-generic-password",
             "-s",
             label,

src/keychain.rs

@@ -10,7 +10,6 @@ use anyhow::Result;
 use clap::Parser;
 use colored::Colorize;
 use dialoguer::{theme::ColorfulTheme, Confirm};
-use dirs;
 use futures::future::join_all;
 use std::fs;
 use std::path::{Path, PathBuf};
@@ -203,10 +202,8 @@ async fn main() -> Result<()> {
         }
 
         let parallel_results = join_all(handles).await;
-        for result in parallel_results {
-            if let Ok(task_result) = result {
-                results.push(task_result);
-            }
+        for task_result in parallel_results.into_iter().flatten() {
+            results.push(task_result);
         }
     }
 
@@ -265,14 +262,13 @@ fn init_config(path: Option<&PathBuf>) -> Result<()> {
     fs::create_dir_all(&config_dir)?;
     let config_path = config_dir.join("config.toml");
 
-    if config_path.exists() {
-        if !Confirm::with_theme(&ColorfulTheme::default())
+    if config_path.exists()
+        && !Confirm::with_theme(&ColorfulTheme::default())
             .with_prompt("Config file already exists. Overwrite?")
             .default(false)
             .interact()?
-        {
-            return Ok(());
-        }
+    {
+        return Ok(());
     }
 
     let default_config = Config::default();

src/main.rs

@@ -34,7 +34,7 @@ pub fn display_system_info() -> Result<()> {
     println!("{}", "─".repeat(DIVIDER_WIDTH).dimmed());
 
     // Disk space
-    if let Ok(output) = Command::new("df").args(&["-h", "/"]).output() {
+    if let Ok(output) = Command::new("df").args(["-h", "/"]).output() {
         if output.status.success() {
             let lines = String::from_utf8_lossy(&output.stdout);
             if let Some(line) = lines.lines().nth(1) {
@@ -52,7 +52,7 @@ pub fn display_system_info() -> Result<()> {
     }
 
     // Battery status
-    if let Ok(output) = Command::new("pmset").args(&["-g", "batt"]).output() {
+    if let Ok(output) = Command::new("pmset").args(["-g", "batt"]).output() {
         if output.status.success() {
             let info = String::from_utf8_lossy(&output.stdout);
             if let Some(line) = info.lines().nth(1) {