Commit fa7fed4
authored
[patch] fix qr base64 encoding function (#1079)
# Pull Request Template
## Description
In
https://github.com/BranchMetrics/web-branch-deep-linking-attribution/pull/1075/files,
i tried to clean up the function a little bit. However, i broke it. So,
i returned the function to normal, but instead jammed the new encoding
of the bytes in. So all should be good
Fixes # (issue)
## Type of change
Please delete options that are not relevant.
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update
## How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
- [ ] Unit test
- [ ] Integration test
## JS Budget Check
Please mention the size in kb before abd after this PR
| Files | Before | After |
| ----------- | ----------- | ----------- |
| dist/build.js. | | |
| dist/build.min.js| | |
## Checklist:
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any dependent changes have been merged and published in downstream
modules
- [ ] I have checked my code and corrected any misspellings
## Mentions:
List the person or team responsible for reviewing proposed changes.
cc @BranchMetrics/saas-sdk-devs for visibility.1 parent b474851 commit fa7fed4
3 files changed
+48
-42
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3106 | 3106 | | |
3107 | 3107 | | |
3108 | 3108 | | |
3109 | | - | |
3110 | | - | |
3111 | | - | |
| 3109 | + | |
| 3110 | + | |
3112 | 3111 | | |
3113 | | - | |
3114 | | - | |
3115 | | - | |
| 3112 | + | |
| 3113 | + | |
| 3114 | + | |
| 3115 | + | |
| 3116 | + | |
| 3117 | + | |
| 3118 | + | |
| 3119 | + | |
| 3120 | + | |
3116 | 3121 | | |
3117 | 3122 | | |
3118 | 3123 | | |
| |||
0 commit comments