ADA-233: Remove role attribute from nav elements

yzhoubk · yzhoubk · commit 35eef503541e · 2025-06-18T10:40:18.000-07:00
diff --git a/app/views/layouts/blacklight/base.html.erb b/app/views/layouts/blacklight/base.html.erb
@@ -38,7 +38,7 @@
 </head>
 
 <body class="<%= render_body_class %>">
-    <nav id="skip-link" role="navigation" aria-label="<%= t('blacklight.skip_links.label') %>">
+    <nav id="skip-link" aria-label="<%= t('blacklight.skip_links.label') %>">
         <%= link_to t('blacklight.skip_links.search_field'), '#search_field', class: 'element-invisible element-focusable rounded-bottom py-2 px-3', data: { turbolinks: 'false' } %>
         <%= link_to t('blacklight.skip_links.main_content'), '#main-container', class: 'element-invisible element-focusable rounded-bottom py-2 px-3', data: { turbolinks: 'false' } %>
         <%= content_for(:skip_links) %>
diff --git a/app/views/shared/_header_navbar.html.erb b/app/views/shared/_header_navbar.html.erb
@@ -1,4 +1,4 @@
-<nav class="navbar navbar-expand-md border-bottom topbar" role="navigation">
+<nav class="navbar navbar-expand-md border-bottom topbar">
     <div class="container">
         <%= link_to (image_tag 'geodata_logo_color.svg', {:"data-svg-fallback" => "#{image_path('geodata_logo.png')}", :alt => 'GeoData @ UC Berkeley'}), root_path %>
         <button class="navbar-toggler navbar-toggler-right" type="button" data-toggle="collapse" data-target="#user-util-collapse" aria-controls="user-util-collapse" aria-expanded="false" aria-label="Toggle navigation">

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-<nav class="navbar navbar-expand-md border-bottom topbar" role="navigation">`
	`1`	`+<nav class="navbar navbar-expand-md border-bottom topbar">`
`2`	`2`	`<div class="container">`
`3`	`3`	`<%= link_to (image_tag 'geodata_logo_color.svg', {:"data-svg-fallback" => "#{image_path('geodata_logo.png')}", :alt => 'GeoData @ UC Berkeley'}), root_path %>`
`4`	`4`	`<button class="navbar-toggler navbar-toggler-right" type="button" data-toggle="collapse" data-target="#user-util-collapse" aria-controls="user-util-collapse" aria-expanded="false" aria-label="Toggle navigation">`