Skip to content

Commit 2516f9f

Browse files
committed
changes made to facet display grid styles
a slight rework of the facet views to work with all browsers see WEB-652
1 parent 9d76da0 commit 2516f9f

6 files changed

Lines changed: 37 additions & 16 deletions

File tree

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,6 @@
6464
},
6565
"./css": "./dist/style.css"
6666
},
67-
"version": "0.0.4",
67+
"version": "0.0.10",
6868
"packageManager": "[email protected]"
6969
}

src/components/Facet.vue

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,8 @@ function onToggle (event: Event) {
4545

4646
<style lang="scss">
4747
fieldset.galc-facet {
48-
display: contents;
48+
display: inherit;
49+
border: none;
4950
5051
legend {
5152
position: absolute;
@@ -54,7 +55,8 @@ fieldset.galc-facet {
5455
}
5556
5657
details {
57-
display: contents;
58+
display: inherit;
59+
border: none;
5860
5961
summary {
6062
list-style: none;

src/components/Facets.vue

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ div.galc-facets {
9494
9595
form.galc-facet-form {
9696
display: grid;
97-
grid-template-columns: min-content max-content minmax(0, 1fr);
97+
grid-template-columns: 1fr;
9898
align-items: center;
9999
justify-items: start;
100100
@@ -110,6 +110,8 @@ div.galc-facets {
110110
}
111111
112112
> fieldset {
113+
padding-bottom: 0;
114+
width: 100%;
113115
114116
details {
115117
summary {
@@ -127,11 +129,11 @@ div.galc-facets {
127129
fieldset {
128130
129131
input {
130-
grid-column: 2;
132+
grid-column: 1;
131133
}
132134
133135
label {
134-
grid-column: 3 / 4;
136+
grid-column: 2 / 4;
135137
}
136138
}
137139
}

src/components/InternalFields.vue

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,8 @@ function onToggle (event: Event) {
3535
// TODO: share styles w/Facet, TermSelection, Suppressed
3636
3737
fieldset.galc-facet {
38-
display: contents;
38+
display: inherit;
39+
border: none;
3940
4041
legend {
4142
position: absolute;
@@ -44,7 +45,8 @@ fieldset.galc-facet {
4445
}
4546
4647
details {
47-
display: contents;
48+
display: inherit;
49+
border: none;
4850
4951
summary {
5052
list-style: none;
@@ -87,7 +89,8 @@ fieldset.galc-facet {
8789
}
8890
8991
div.galc-term-selection {
90-
display: contents;
92+
display: inherit;
93+
border: none;
9194
9295
@media only screen and (max-width: 700px) {
9396
font-size: 1.125rem;
@@ -111,7 +114,8 @@ div.galc-term-selection {
111114
}
112115
113116
fieldset.galc-facet-subterms {
114-
display: contents;
117+
display: inherit;
118+
border: none;
115119
}
116120
}
117121

src/components/Suppressed.vue

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,8 @@ function onToggle (event: Event) {
4444
// TODO: share styles w/Facet, TermSelection
4545
4646
fieldset.galc-facet {
47-
display: contents;
47+
display: inherit;
48+
border: none;
4849
4950
legend {
5051
position: absolute;
@@ -53,7 +54,8 @@ fieldset.galc-facet {
5354
}
5455
5556
details {
56-
display: contents;
57+
display: inherit;
58+
border: none;
5759
5860
summary {
5961
list-style: none;
@@ -96,7 +98,8 @@ fieldset.galc-facet {
9698
}
9799
98100
div.galc-term-selection {
99-
display: contents;
101+
display: inherit;
102+
border: none;
100103
101104
@media only screen and (max-width: 700px) {
102105
font-size: 1.125rem;
@@ -120,7 +123,11 @@ div.galc-term-selection {
120123
}
121124
122125
fieldset.galc-facet-subterms {
123-
display: contents;
126+
display: inherit;
127+
border: none;
128+
padding-top: 0;
129+
padding-bottom: 0;
130+
padding-left: 1.3em;
124131
}
125132
}
126133

src/components/TermSelection.vue

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,12 @@ const selected = selectedTerms(props.facet.name)
3737

3838
<style lang="scss">
3939
div.galc-term-selection {
40-
display: contents;
40+
border: none;
41+
display: grid;
42+
grid-template-columns: 18px 3fr;
43+
column-gap: 0.5em;
44+
margin-left: 0;
45+
padding-left: 0;
4146
4247
@media only screen and (max-width: 700px) {
4348
font-size: 1.125rem;
@@ -61,7 +66,8 @@ div.galc-term-selection {
6166
}
6267
6368
fieldset.galc-facet-subterms {
64-
display: contents;
69+
display: block;
70+
border: 0;
6571
}
6672
}
6773
</style>

0 commit comments

Comments
 (0)