AP-588 Upgrade Rails to 8.0.x (#20)

* Upgrade Rails to 7.0.10

* Upgrade Rails to 7.1.x and update dependencies

* Upgrade Rails to 7.2.x and update dependencies

* Upgrade Rails to 8.0.x and update dependencies

* Upgrade Rails to 8.0.5

* fix database connection

* Rails 8 requires a secret_key_base so setting it to a dummy value for testing

* Add test to make sure 404 response is handled gracefully

* Bump bundler to v2.7.2

* Change to verify which is better than active

* Ran app:update

* Update a couple of items to new versions and tweak git build

* Revert git build to use dummy secret for validating DB migrations

* Update default initializers 7_1 and 7_2

* Update default initializers 8_0

* Updating config.load_defaults to 8.0 after testing all initializers for 7.1, 7.2 and 8.0

Author: steve-sullivan

.github/workflows/build.yml

@@ -132,8 +132,9 @@ jobs:
       - name: Validate database migrations
         env:
           RAILS_ENV: production
+          SECRET_KEY_BASE: dummy_test_secret_key_base
           DISABLE_DATABASE_ENVIRONMENT_CHECK: 1
-        run: rails --trace db:drop db:create db:migrate
+        run: bundle exec rails --trace db:drop db:create db:migrate
 
       - name: Upload artifacts
         if: ${{ always() }}

.rubocop.yml

@@ -1,7 +1,8 @@
-require:
+plugins:
   - rubocop-rails
 
 AllCops:
+  TargetRailsVersion: 8.0
   UseCache: false
   Exclude:
     # Exclude generated files
@@ -185,7 +186,7 @@ Lint/TripleQuotes: # (new in 1.9)
   Enabled: true
 Style/IfWithBooleanLiteralBranches: # (new in 1.9)
   Enabled: true
-Gemspec/DateAssignment: # (new in 1.10)
+Gemspec/DeprecatedAttributeAssignment:
   Enabled: true
 Style/HashConversion: # (new in 1.10)
   Enabled: true

Dockerfile

@@ -29,13 +29,13 @@ RUN mkdir -p /opt/app \
 # ------------------------------------------------------------
 # Install packages common to dev and prod.
 
-# Get list of available packages
-RUN apt-get update -qq
-
 # Install standard packages from the Debian repository
-RUN apt-get install -y --no-install-recommends \
+RUN apt-get update -qq && apt-get install -y --no-install-recommends \
     libpq-dev \
-    libvips42
+    libvips42 \
+    libyaml-dev \
+    pkg-config \
+  && rm -rf /var/lib/apt/lists/*
 
 # ------------------------------------------------------------
 # Run configuration
@@ -75,10 +75,11 @@ FROM base AS development
 USER root
 
 # Install system packages needed to build gems with C extensions.
-RUN apt-get install -y --no-install-recommends \
+RUN apt-get update -qq && apt-get install -y --no-install-recommends \
     gcc \
     g++ \
-    make
+    make \
+  && rm -rf /var/lib/apt/lists/*
 
 # ------------------------------------------------------------
 # Install Ruby gems
@@ -87,7 +88,7 @@ RUN apt-get install -y --no-install-recommends \
 USER $APP_USER
 
 # Base image ships with an older version of bundler
-RUN gem install bundler --version 2.5.22
+RUN gem install bundler --version 2.7.2
 
 # Install gems. We don't enforce the validity of the Gemfile.lock until the
 # final (production) stage.

Gemfile

@@ -5,21 +5,22 @@ ruby '~> 3.3'
 
 gem 'berkeley_library-alma', '~> 0.1.1'
 gem 'berkeley_library-logging', '~> 0.3'
-gem 'berkeley_library-util', '~> 0.2.0'
+gem 'berkeley_library-util', '~> 0.3'
 gem 'drb'
 gem 'image_processing', '~> 1.12'
 gem 'jsonapi.rb', '~> 2.0'
 gem 'jsonapi-serializer', '~> 2.2'
 gem 'jwt', '~> 2.4'
 gem 'mutex_m'
-gem 'omniauth', '~> 1.9', '>= 1.9.2'
-gem 'omniauth-cas', '~> 2.0'
+gem 'omniauth', '~> 2.1'
+gem 'omniauth-cas', '~> 3.0'
+gem 'omniauth-rails_csrf_protection', '~> 1.0'
 gem 'pg', '~> 1.4'
 gem 'pg_search', '~> 2.3'
-gem 'puma', '~> 5.0'
+gem 'puma', '~> 7.2'
 gem 'rack-cors'
-gem 'rails', '~> 7.0.4'
-gem 'ransack', '~> 2.6'
+gem 'rails', '~> 8.0.5'
+gem 'ransack', '~> 4.2'
 gem 'zaru', '~> 0.3.0'
 
 group :development, :test do
@@ -30,19 +31,20 @@ end
 
 group :development do
   gem 'hashdiff', '~> 1.0.1'
-  gem 'rubocop', '~> 1.26.0'
-  gem 'rubocop-rails', '~> 2.13.2', require: false
-  gem 'rubocop-rspec', '~> 2.4.0', require: false
+  gem 'rubocop', '~> 1.86'
+  gem 'rubocop-rails', '~> 2.34', require: false
+  gem 'rubocop-rspec', '~> 3.6', require: false
+  gem 'rubocop-rspec_rails', '~> 2.30', require: false
 end
 
 group :test do
   gem 'database_cleaner-active_record', '~> 2.0'
   gem 'factory_bot_rails'
   gem 'rails-controller-testing'
-  gem 'rspec', '~> 3.10'
-  gem 'rspec_junit_formatter', '~> 0.5'
-  gem 'rspec-rails', '~> 5.0'
-  gem 'simplecov', '~> 0.21', require: false
-  gem 'simplecov-rcov', '~> 0.2', require: false
+  gem 'rspec', '~> 3.13'
+  gem 'rspec_junit_formatter', '~> 0.6'
+  gem 'rspec-rails', '~> 8.0'
+  gem 'simplecov', '~> 0.22', require: false
+  gem 'simplecov-rcov', '~> 0.3', require: false
   gem 'webmock', require: false
 end