models: Validate Bibliographic::HostBibTask.email

This ensures we do not create jobs without email addresses.

Closes: AP-577

Author: awilfox

.idea/altmedia.iml

@@ -6,6 +6,7 @@ class HostBibTask < ActiveRecord::Base
       succeeded: 6,
       failed: 9
     }, default: :starting
+    validates :email, presence: true
 
     class << self
       def create_from!(file, email)

app/models/bibliographic/host_bib_task.rb

@@ -2,7 +2,7 @@
 
 module Bibliographic
   RSpec.describe Report do
-    let(:host_bib_task) { Bibliographic::HostBibTask.create(filename: 'fake.txt') }
+    let(:host_bib_task) { Bibliographic::HostBibTask.create(filename: 'fake.txt', email: '[email protected]') }
     let(:report) { described_class.new(host_bib_task, 6) }
 
     # succeed mmsids for csv content

spec/lib/bibliographic/report_spec.rb

@@ -4,7 +4,7 @@
 RSpec.describe Bibliographic::HostBib, type: :model do
   let(:record_id) { double('record_id') }
   let(:mms_id) { '991083840969706532' }
-  let(:host_bib_task) { Bibliographic::HostBibTask.create(filename: 'fake.txt') }
+  let(:host_bib_task) { Bibliographic::HostBibTask.create(filename: 'fake.txt', email: '[email protected]') }
   let(:marc_stub) { instance_double(MARC::Record) }
   let(:expected_subfields) { { 'w' => '991083840969706532', 't' => 'Seconde partie du discours aux Welches ' } }
 
@@ -42,6 +42,22 @@ def marc_stub
     end
   end
 
+  describe 'task creation' do
+    context 'without an email address' do
+      it 'is invalid' do
+        task = Bibliographic::HostBibTask.new(filename: 'fake.txt', email: nil)
+        expect(task).to be_invalid
+      end
+    end
+
+    context 'with an email address' do
+      it 'is valid' do
+        task = Bibliographic::HostBibTask.new(filename: 'fake.txt', email: '[email protected]')
+        expect(task).to be_valid
+      end
+    end
+  end
+
   context 'host_bib not nil' do
     it_behaves_like 'host_bib has alma marc', 'pending'
     it_behaves_like 'host_bib has alma marc', 'retrieving'

spec/models/host_bib_spec.rb

@@ -3,7 +3,7 @@
 
 RSpec.describe Bibliographic::LinkedBib, type: :model do
   let(:mms_id) { '991083840969706532' }
-  let(:host_bib_task) { Bibliographic::HostBibTask.create(filename: 'fake.txt') }
+  let(:host_bib_task) { Bibliographic::HostBibTask.create(filename: 'fake.txt', email: '[email protected]') }
   let(:host_bib) { host_bib_task.host_bibs.create(mms_id:) }
   let(:subfields_from_774) { { 'w' => '991083840969706532', 't' => 'Seconde partie du discours aux Welches ' } }