Allow this state and props in secondary callback.

Allow this state and props in secondary callback.

Author: BE-Webdesign

lib/rules/no-this-state-props.js

@@ -33,6 +33,19 @@ module.exports = {
       }
     }
 
+    function isThisSetStateCallback (node) {
+      if ( node.parent && node.parent.type === 'CallExpression' ) {
+        var parent = node.parent;
+        var isMatching = (
+          isThisSetState(parent) &&
+          parent.arguments &&
+          parent.arguments.length > 1 &&
+          parent.arguments[1] === node
+        )
+        return isMatching
+      }
+    }
+
     function isThisState(node) {
       var isMatching = (
         node.type === 'MemberExpression' &&
@@ -79,7 +92,7 @@ module.exports = {
       MemberExpression: function(node) {
         if ( isThisProps(node) || isThisState(node) ) {
           var ancestors = context.getAncestors()
-          if ( ancestors.some(isThisSetState) ) {
+          if ( ancestors.some(isThisSetState) && !ancestors.some(isThisSetStateCallback) ) {
             var setStateUsage = ancestors.find(isThisSetState)
             setStateUsages.push(setStateUsage);
           }

tests/lib/rules/index.js

@@ -31,6 +31,10 @@ ruleTester.run("no-this-state-props", rule, {
             code: "this.setState( ( state, props ) => ( { opened: ! props.open } ) )",
             parserOptions: { ecmaVersion: 6 }
         },
+        {
+            code: "this.setState( ( state, props ) => ( { opened: ! props.open } ), () => ( { state: this.state } ) )",
+            parserOptions: { ecmaVersion: 6 }
+        },
         {
             code: "var yolo = this.state.yolo; this.setState( ( state, props ) => ( { opened: ! props.open } ) )",
             parserOptions: { ecmaVersion: 6 }