[js-automation] stop clearing package directory before SDK generation

[jeremymeng]

Today we clear package directory for some packages when js automation generate SDK from spec changes:

• https://github.com/Azure/azure-sdk-tools/blob/9d019be84d5db26c1b0f976d13ffd21c771442a4/tools/js-sdk-release-tools/src/mlc/clientGenerator/modularClientPackageGenerator.ts#L35
• https://github.com/Azure/azure-sdk-tools/blob/5ce0fdaf423d78e5a5fcca3450af1cebe7af166e/tools/js-sdk-release-tools/src/llc/generateRLCInPipeline/generateRLCInPipeline.ts#L55

This works around potential build breaks from packages' customization, but leads to other undesirable results, including

• loss of customization API from apiview of the automation PR

We should stop clearing package directories and fix any blocking issues instead. We also need to ensure customizations are applied properly in the automation.

[jeremymeng]

@MaryGao @qiaozha

[MaryGao]

I believe we have sorted out the cleanup logic among automation and codegen in issue: Azure/azure-sdk-tools#12096. @skywing918 Could you summerize the current cleanup logic in two parts here? And let's work out where to improve with Jeremy for their scenaiors.

[skywing918]

Summerize the current cleanup logic
RLC:

• In local and release modes

  • clean src folder (by emitter)
  • clean sample dev folder if generate-sample == true (by emitter)
  • clean sample folder (by release tool)

• In SpecPullRequest and Batch modes

  • clean up everything (by release tool)

Modular

• mgmt:
  • modular->modular
    • clean src folder (by emitter)
    • clean sample dev folder if generate-sample == true (by emitter)
    • clean sample folder (by release tool)
  • hlc->modular
    • clean up everything (by release tool)
  • hlc->hlc
    • clean up everything (by release tool)
• dpg:
  • In local and release modes
    • clear src folder (by emitter)
    • clean sample dev folder if generate-sample == true (by emitter)
    • clean sample folder (by release tool)
  • In SpecPullRequest and Batch modes
    • clean up everything (by release tool)

cc: @MaryGao

[jeremymeng]

@skywing918 thanks for the breakdowns! One concern is that for existing packages the SDK Validation pipeline may generate a different ApiView, if they have additional custom code after dev-tool customization apply-v2

[MaryGao]

@jeremymeng Could you help me understand your use case? Do you mean during the API view generated in Spec PR review we should apply the customization code? Or you mean the AutoRPs triggered manually by customers should include customizations?

I am asking because the different trigger sources would have different handling by our tool. I believe the cases you mentioned are for data-plane SDKs, no customization in MPG yet. As we mentioned above in different modes we would have different cleanup logic by automation pipeline, e.g SpecPullRequest mode for spec pr review, release model for AutoPR preparation in SDK repo.

• dpg:
  • In local and release modes
    • clear src folder (by emitter)
    • clean sample dev folder if generate-sample == true (by emitter)
    • clean sample folder (by release tool)
  • In SpecPullRequest and Batch modes
    • clean up everything (by release tool)

The customization is guareented by both emitter and automation script, if we have source folder like src/generated or generated. Then emitters would directly generate code there. And in automation we would always call customization apply-v2 -s ./generated -c ./src command because calling failure would just be a warning.