-
Notifications
You must be signed in to change notification settings - Fork 230
Description
This issue is for a: (mark with an x)
- [X] bug report -> please search issues before submitting
- [ ] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)
Minimal steps to reproduce
Follow the steps on Microsoft Learn for the exercise on working with Azure Event Grid and custom events: https://learn.microsoft.com/en-us/training/modules/azure-event-grid/8-event-grid-custom-events
When deploying the Azure Event Grid viewer sample, the deployment fails to fetch the source files from GitHub. The error message in the Azure deployment logs indicates the value for 'SCM' is incorrect.
Possible solution
After searching online, I found that adding the following snipit to [azuredeploy.json](https://github.com/Azure-Samples/azure-event-grid-viewer/blob/main/azuredeploy.json) fixes the problem;
Under the resources of the Microsoft.Web/sites resource add
{
"type": "config",
"apiVersion": "2021-03-01",
"name":"web",
"location":"[parameters('location')]",
"dependsOn": [
"[resourceId('Microsoft.Web/sites', parameters('siteName'))]"
],
"properties":{
"scmType": "GitHub",
"scmMinTlsVersion": "1.2"
}
}I'm not very familiar with ARM templates, so I don't know if this is the best solution. But at least it points in the right direction for others who might get stuck when following the exercise mentioned above.