Exceptions are swallowed at non-event handler callsites when ExceptionHandler is null

[udlose]

There are classes that take an Action<Exception> exceptionHandler as a param to the ctor. A value of null is acceptable and valid.

Example:

protected GenericLineTransformer(Action<Exception> exceptionHandler)
{
    _exceptionHandler = exceptionHandler;
}

Here is an example of a non-event handler callsite:

GenericLineTransformer:ColorizeLine

protected override void ColorizeLine(DocumentLine line)
{
    try
    {
        TransformLine(line, CurrentContext);
    }
    catch (Exception ex)
    {
        _exceptionHandler?.Invoke(ex);
    }
}

If _exceptionHandler is null, exceptions caught here are swallowed. This isn't intuitive. I would assume that if I don't supply an _exceptionHandler, all exceptions would not be handled (or swallowed). @danipen has confirmed that the current behavior is not correct.

Important

The one exception to the rule is event handlers - by design, per Microsoft, event handlers should never throw exceptions.

[udlose]

@danipen what are the requirements for where the try/catch with _exceptionHandler should be used? All public methods? All event handlers? Both public methods and event handlers? Something else?

The _exceptionHandler is not implemented consistently in classes. For example, in the GenericLineTransformer class, it is only implemented in ColorizeLine, but it isn't implemented in SetTextStyle.