Encode the path before creating the download URL.

LTLA · LTLA · commit a6021c63b8a1 · 2025-08-18T18:01:08.000-07:00
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,6 +1,6 @@
 Package: gobbler
-Version: 0.3.17
-Date: 2025-07-02
+Version: 0.3.18
+Date: 2025-08-18
 Title: Interface to the gobbler service
 Description:
     Friendly interface to the gobbler service.
diff --git a/R/fetchDirectory.R b/R/fetchDirectory.R
@@ -101,7 +101,7 @@ fetchDirectory <- function(path, registry, url, cache=NULL, forceRemote=FALSE, o
     final
 }
 
-#' @importFrom utils download.file
+#' @importFrom utils download.file URLencode
 acquire_file_raw <- function(cache, path, url, overwrite) {
     target <- file.path(cache, "REGISTRY", path)
 
@@ -111,7 +111,7 @@ acquire_file_raw <- function(cache, path, url, overwrite) {
         tempf <- tempfile(tmpdir=tempdir)
         on.exit(unlink(tempf), add=TRUE, after=FALSE)
 
-        if (download.file(paste0(url, "/fetch/", path), tempf)) {
+        if (download.file(paste0(url, "/fetch/", URLencode(path, reserved=TRUE)), tempf)) {
             stop("failed to download '", path, "' from the registry")
         }
         dir.create(dirname(target), recursive=TRUE, showWarnings=FALSE)

Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,7 @@ fetchDirectory <- function(path, registry, url, cache=NULL, forceRemote=FALSE, o`
`101`	`101`	`final`
`102`	`102`	`}`
`103`	`103`
`104`		`-#' @importFrom utils download.file`
	`104`	`+#' @importFrom utils download.file URLencode`
`105`	`105`	`acquire_file_raw <- function(cache, path, url, overwrite) {`
`106`	`106`	`target <- file.path(cache, "REGISTRY", path)`
`107`	`107`
`@@ -111,7 +111,7 @@ acquire_file_raw <- function(cache, path, url, overwrite) {`
`111`	`111`	`tempf <- tempfile(tmpdir=tempdir)`
`112`	`112`	`on.exit(unlink(tempf), add=TRUE, after=FALSE)`
`113`	`113`
`114`		`- if (download.file(paste0(url, "/fetch/", path), tempf)) {`
	`114`	`+ if (download.file(paste0(url, "/fetch/", URLencode(path, reserved=TRUE)), tempf)) {`
`115`	`115`	`stop("failed to download '", path, "' from the registry")`
`116`	`116`	`}`
`117`	`117`	`dir.create(dirname(target), recursive=TRUE, showWarnings=FALSE)`