chore!: rename dict:contains to dict:contains\? for consistency with the other functions returning booleans

SuperFola · SuperFola · commit 243bfbbc8c17 · 2025-12-01T18:12:18.000+01:00
diff --git a/.envrc b/.envrc
@@ -1,3 +1,4 @@
 #!/usr/bin/env bash
 
-export PATH="$(pwd)/tools:$PATH"
+export ARKSCRIPT_PATH="$(pwd)/lib"
+export PATH="$(pwd)/tools:$(pwd)/cmake-build-debug:$PATH"
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,7 @@
 
 ### Changed
 - the formatter properly formats dictionaries (key-value pairs on their own line, always)
+- renamed `dict:contains` to `dict:contains?` so that all functions returning booleans have `?` suffix ; added temporary alias `dict:contains`
 
 ### Removed
 
diff --git a/lib/std b/lib/std
@@ -1 +1 @@
-Subproject commit 15ea724606100353f41210a65203f47062e6b2d3
+Subproject commit e5a2f265e755506390c2875f5d65fc41141c185a
diff --git a/src/arkreactor/Builtins/Dict.cpp b/src/arkreactor/Builtins/Dict.cpp
@@ -63,7 +63,7 @@ namespace Ark::internal::Builtins::Dict
     {
         if (!types::check(n, ValueType::Dict, ValueType::Any))
             throw types::TypeCheckingError(
-                "dict:contains",
+                "dict:contains?",
                 { { types::Contract { { types::Typedef("dictionary", ValueType::Dict),
                                         types::Typedef("key", ValueType::Any) } } } },
                 n);
diff --git a/tests/unittests/resources/DiagnosticsSuite/typeChecking/dict_contains_num.expected b/tests/unittests/resources/DiagnosticsSuite/typeChecking/dict_contains_num.expected
@@ -1,4 +1,4 @@
-Function dict:contains expected 2 arguments but got 1
+Function dict:contains? expected 2 arguments but got 1
   -> dictionary (Dict) was of type Number
   -> key (any) was not provided
 

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ namespace Ark::internal::Builtins::Dict`
`63`	`63`	`{`
`64`	`64`	`if (!types::check(n, ValueType::Dict, ValueType::Any))`
`65`	`65`	`throw types::TypeCheckingError(`
`66`		`- "dict:contains",`
	`66`	`+ "dict:contains?",`
`67`	`67`	`{ { types::Contract { { types::Typedef("dictionary", ValueType::Dict),`
`68`	`68`	`types::Typedef("key", ValueType::Any) } } } },`
`69`	`69`	`n);`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-Function dict:contains expected 2 arguments but got 1`
	`1`	`+Function dict:contains? expected 2 arguments but got 1`
`2`	`2`	`-> dictionary (Dict) was of type Number`
`3`	`3`	`-> key (any) was not provided`
`4`	`4`