refactor: remove unused get bytes transaction method (#157)

Author: alexbarnsley

crypto/transactions/serializer.py

@@ -11,10 +11,6 @@ def __init__(self, transaction: AbstractTransaction):
     def new(transaction: AbstractTransaction):
         return Serializer(transaction)
 
-    @staticmethod
-    def get_bytes(transaction: AbstractTransaction, skip_signature: bool = False) -> bytes:
-        return transaction.serialize(skip_signature=skip_signature)
-
     def serialize(self, skip_signature: bool = False) -> bytes:
         transaction_hash = TransactionUtils.to_buffer(self.transaction.data, skip_signature=skip_signature).decode()
 

crypto/transactions/types/abstract_transaction.py

@@ -24,11 +24,6 @@ def refresh_payload_data(self):
     def get_id(self) -> str:
         return TransactionUtils.get_id(self.data)
 
-    def get_bytes(self, skip_signature: bool = False) -> bytes:
-        from crypto.transactions.serializer import Serializer
-
-        return Serializer.get_bytes(self, skip_signature)
-
     def sign(self, private_key: PrivateKey):
         transaction_hash = TransactionUtils.to_buffer(self.data, skip_signature=True).decode()
 

tests/transactions/test_transaction.py

@@ -27,11 +27,6 @@ def test_verify_transaction(load_transaction_fixture):
     transaction = Deserializer.new(load_transaction_fixture('transfer')['serialized']).deserialize()
     assert transaction.verify()
 
-def test_transaction_to_bytes(load_transaction_fixture):
-    transaction = Deserializer.new(load_transaction_fixture('transfer')['serialized']).deserialize()
-    actual = transaction.get_bytes()
-    assert isinstance(actual, bytes)
-
 def test_transaction_to_array(load_transaction_fixture):
     transaction = Deserializer.new(load_transaction_fixture('transfer')['serialized']).deserialize()
     actual = transaction.to_dict()