[O2B-1505] LHCfills beam duration filter by Houwie7000 · Pull Request #2035 · AliceO2Group/Bookkeeping

Houwie7000 · 2025-12-02T16:57:03Z

I have a JIRA ticket

branch and/or PR name(s) include(s) JIRA ID
issue has "Fix version" assigned
issue "Status" is set to "In review"
PR labels are selected

Notable changes for users:

Option to filter by beam duration has been added to the LHCfills-page filter.

Notable changes for developers:

Changes made to the database:

…t extracted and reused.

…achine hitting timout threshold

This reverts commit 96a04c0.

Houwie7000 · 2025-12-04T13:20:05Z

Git borked, it seems that it included changes from the previous task in this one...
Edit: fixed

…rontend

…dioButton.js

codecov · 2025-12-08T14:18:51Z

Codecov Report

❌ Patch coverage is 31.81818% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.58%. Comparing base (75d9853) to head (191fd52).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...ilters/common/filters/TextComparisonFilterModel.js	0.00%	18 Missing ⚠️
...nents/Filters/LhcFillsFilter/beamDurationFilter.js	0.00%	4 Missing ⚠️
...c/views/LhcFills/Overview/LhcFillsOverviewModel.js	0.00%	4 Missing ⚠️
...components/Filters/common/filters/rawTextFilter.js	0.00%	1 Missing ⚠️
lib/public/views/Home/Overview/HomePageModel.js	0.00%	1 Missing ⚠️
...ws/LhcFills/ActiveColumns/lhcFillsActiveColumns.js	0.00%	1 Missing ⚠️
lib/utilities/validateTime.js	90.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2035      +/-   ##
==========================================
- Coverage   45.60%   45.58%   -0.02%     
==========================================
  Files        1028     1031       +3     
  Lines       17134    17172      +38     
  Branches     3120     3123       +3     
==========================================
+ Hits         7814     7828      +14     
- Misses       9320     9344      +24

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This reverts commit 695622b.

…ith the query/reset logic. Just set the value afterwards

lib/public/views/LhcFills/Overview/LhcFillsOverviewModel.js

…ture/O2B-1505/lhcfills-beam-duration-filter

Houwie7000 · 2025-12-18T14:34:11Z

Fixing broken tests WIP.....
Result: it was a fluke...

Houwie7000 · 2026-01-12T16:05:53Z

NOTE: 1503 slipped a bit of wrong JSDoc through, lib/utilities/rangeUtils.js LN 47 should indicate an array of strings not string. I'll push a commit here to fix it

…moved, SBDuration filter frontend fixed

lib/utilities/validateTime.js

lib/usecases/lhcFill/GetAllLhcFillsUseCase.js

lib/public/views/LhcFills/Overview/LhcFillsOverviewModel.js

graduta · 2026-01-20T15:32:57Z

It would be great if you could also add some tests for the API /test/lhcFills to ensure API validation for JOI works as expected together with the server

…DO validate tests

lib/public/components/Filters/common/filters/rawTextFilter.js

lib/public/components/Filters/common/filters/TextComparisonFilterModel.js

lib/public/components/Filters/LhcFillsFilter/beamDurationFilter.js

lib/public/views/LhcFills/Overview/LhcFillsOverviewModel.js

test/public/lhcFills/overview.test.js

Houwie7000 added 8 commits November 26, 2025 10:58

[O2B-1502] Filter model setup boilerplate code.

057c235

[O2B-1502] Add filter button on LHC-fills overview page.

a7a9eda

[O2B-1502] Added stable beams only to filter

2648f1c

[O2B-1502] Filtering with Stable Beams Only works, radioButton elemen…

094e6c5

…t extracted and reused.

[O2B-1502] Doc fixes

da7ff37

[O2B-1502] Increase timeout of detailsForSimulationPass test. Local m…

ee72512

…achine hitting timout threshold

[O2B-1502] Potential fix for test failure.

96a04c0

Revert "[O2B-1502] Potential fix for test failure."

6fa4034

This reverts commit 96a04c0.

Houwie7000 requested a review from isaachilly December 2, 2025 16:57

Houwie7000 self-assigned this Dec 2, 2025

Houwie7000 added frontend backend javascript Pull requests that update Javascript code labels Dec 2, 2025

graduta and others added 4 commits December 5, 2025 11:41

Merge branch 'main' into feature/O2B-1502/filtering-panel-lhc-fills-f…

17ea048

…rontend

[O2B-1502] Processed feedback

695622b

[O2B-1502] Git failed to detect rename. Ran: git mv RadioButton.js ra…

87bee89

…dioButton.js

[O2B-1502] Added test import

5a18d9e

Houwie7000 force-pushed the feature/O2B-1503/lhcfills-fill-numbers-filter branch from 56e5c6a to 847d092 Compare December 8, 2025 13:10

Houwie7000 force-pushed the feature/O2B-1505/lhcfills-beam-duration-filter branch from 23dbb7b to 11c1f9d Compare December 8, 2025 14:15

Houwie7000 marked this pull request as ready for review December 8, 2025 15:23

Houwie7000 requested a review from graduta as a code owner December 8, 2025 15:23

Houwie7000 added 6 commits December 10, 2025 13:58

Revert "[O2B-1502] Processed feedback"

4c530ef

This reverts commit 695622b.

[O2B-1502] Cherry pick previous feedback changes

51b50d9

[O2B-1502] Integrated stable beam only filter into filtermodel.

c0c8559

[O2B-1502] fixed stable beam default value

9934e56

[O2B-1502] Fixed logic and type

f247a6f

[O2B-1502] Don't set any defaults in the filter as it will conflict w…

9b67281

…ith the query/reset logic. Just set the value afterwards

Houwie7000 force-pushed the feature/O2B-1503/lhcfills-fill-numbers-filter branch from 847d092 to 3110c29 Compare December 11, 2025 11:12

isaachilly reviewed Dec 16, 2025

View reviewed changes

lib/public/views/LhcFills/Overview/LhcFillsOverviewModel.js Outdated Show resolved Hide resolved

Houwie7000 added 4 commits December 17, 2025 11:02

Merge branch 'main' into feature/O2B-1503/lhcfills-fill-numbers-filter

fd055ca

[O2B-1505] Processed feedback

6a47048

[O2B-1503] Processed feedback, added tests

8e82b34

[O2B-1503] Added test for splitStringToStringsTrimmed()

e5bbc05

Base automatically changed from feature/O2B-1503/lhcfills-fill-numbers-filter to main December 18, 2025 12:51

Houwie7000 added 2 commits December 18, 2025 14:57

Merge branch 'feature/O2B-1503/lhcfills-fill-numbers-filter' into fea…

668f90e

…ture/O2B-1505/lhcfills-beam-duration-filter

Merge branch 'main' into feature/O2B-1505/lhcfills-beam-duration-filter

a047600

Houwie7000 requested a review from isaachilly December 18, 2025 14:56

[O2B-1505] Remove old code

f113473

Houwie7000 and others added 2 commits January 20, 2026 16:04

[O2B-1505] Processed feedback, timeValidator JOI updated, debounce re…

bd1b836

…moved, SBDuration filter frontend fixed

Merge branch 'main' into feature/O2B-1505/lhcfills-beam-duration-filter

9e3bc30

graduta requested changes Jan 20, 2026

View reviewed changes

[O2B-1505] Fixed validateTime error handling, removed unused code, TO…

ff540af

…DO validate tests

isaachilly reviewed Jan 20, 2026

View reviewed changes

Houwie7000 added 5 commits January 21, 2026 12:05

[O2B-1505] processed feedback, empty id, code deduplication, bad doc

9e4e68c

[O2B-1505] API + UI tests added

0af9bdf

[O2B-1505] disable 00:00:00 conversion to null for DB

45acea2

[O2B-1505] typo removed

4a4ed6d

[O2B-1505] Removed outdated 00:00:00 usecase test

133aa01

graduta previously approved these changes Jan 21, 2026

View reviewed changes

[O2B-1505] amountFilter -> durationFilter

191fd52

Houwie7000 dismissed graduta’s stale review via 191fd52 January 21, 2026 14:31

graduta approved these changes Jan 21, 2026

View reviewed changes

isaachilly approved these changes Jan 21, 2026

View reviewed changes

graduta merged commit 5fd8dba into main Jan 21, 2026
22 of 24 checks passed

graduta deleted the feature/O2B-1505/lhcfills-beam-duration-filter branch January 21, 2026 14:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[O2B-1505] LHCfills beam duration filter#2035

[O2B-1505] LHCfills beam duration filter#2035
graduta merged 55 commits intomainfrom
feature/O2B-1505/lhcfills-beam-duration-filter

Houwie7000 commented Dec 2, 2025 •

edited by graduta

Loading

Uh oh!

Houwie7000 commented Dec 4, 2025 •

edited

Loading

Uh oh!

codecov bot commented Dec 8, 2025 •

edited

Loading

Uh oh!

Uh oh!

Houwie7000 commented Dec 18, 2025 •

edited

Loading

Uh oh!

Houwie7000 commented Jan 12, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

graduta commented Jan 20, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

Houwie7000 commented Dec 2, 2025 • edited by graduta Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I have a JIRA ticket

Notable changes for developers:

Changes made to the database:

Uh oh!

Houwie7000 commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Houwie7000 commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Houwie7000 commented Jan 12, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

graduta commented Jan 20, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Comments

Houwie7000 commented Dec 2, 2025 •

edited by graduta

Loading

Houwie7000 commented Dec 4, 2025 •

edited

Loading

codecov bot commented Dec 8, 2025 •

edited

Loading

Houwie7000 commented Dec 18, 2025 •

edited

Loading